Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import types don't create dependencies #35

Closed
sandersn opened this issue Feb 13, 2019 · 0 comments · Fixed by #95
Closed

import types don't create dependencies #35

sandersn opened this issue Feb 13, 2019 · 0 comments · Fixed by #95
Labels
publisher

Comments

@sandersn
Copy link
Member

In module-info.ts:imports, ImportType is not a handled SyntaxKind. But they should behave the same as an import declaration.

This caused a problem in DefinitelyTyped/DefinitelyTyped#32891 which had to be fixed in DefinitelyTyped/DefinitelyTyped#33030 by adding a triple-slash reference, for example.
@andrewbranch andrewbranch transferred this issue from microsoft/types-publisher Jun 4, 2020
@jablko jablko mentioned this issue Aug 27, 2020
Merged
sandersn pushed a commit that referenced this issue Nov 29, 2021
@sandersn
Merge pull request #35 from Microsoft/recommended
083a0bc 
Use "tslint:recommended" instead of "tslint:latest"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
publisher
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add dependencies for import types jablko/DefinitelyTyped-tools
2 participants
@sandersn @andrewbranch