Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library target should be netstandard2.0 or netstandard2.0;net462 or net5.0 #139

Closed
baywet opened this issue Nov 19, 2021 · 0 comments · Fixed by #184
Closed

library target should be netstandard2.0 or netstandard2.0;net462 or net5.0 #139

baywet opened this issue Nov 19, 2021 · 0 comments · Fixed by #184
Assignees
Labels
type:bug A broken experience
Milestone

Comments

@baywet
Copy link
Member

baywet commented Nov 19, 2021

The library used to target netstandard2.0;net461 as this was a previous recommendation from the dotnet team

✔️ CONSIDER adding a target for net461 when you're offering a netstandard2.0 target.
Using .NET Standard 2.0 from .NET Framework has some issues that were addressed in .NET Framework 4.7.2. You can improve the experience for developers that are still on .NET Framework 4.6.1 - 4.7.1 by offering them a binary that is built for .NET Framework 4.6.1.

However, it was updated to netstandard2.0;net472 following the Sha1 deprecation, this update should actually have been targeting netstandard2.0;net462.

This is because net472 already implements netstandard2.0 and doesn't suffer from the same compatibility quirks 4.6 does. Effectively, this current target doesn't add any additional compatibility compared with netstandard2.0.

We could either:

  • fix the target to netstandard2.0;net462 to get the broadest compatibility
  • remove the net472 target since the audience relying on net462 and net471 must be quite small
  • move to net5.0 (which would arguably leave a lot of people behind)

Let's wait to see if there is any customer demand for 462 compatibility before changing anything here.

@baywet baywet added the type:bug A broken experience label Nov 23, 2021
@adhiambovivian adhiambovivian added this to the 1.1 milestone Feb 23, 2022
@baywet baywet linked a pull request Feb 24, 2022 that will close this issue
@baywet baywet modified the milestones: 1.1, 1.0.10 Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug A broken experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants