Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OData actions are applied to derived types #221

Closed
peombwa opened this issue May 19, 2022 · 7 comments · Fixed by #226
Closed

OData actions are applied to derived types #221

peombwa opened this issue May 19, 2022 · 7 comments · Fixed by #226
Assignees
Labels
priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days
Milestone

Comments

@peombwa
Copy link
Contributor

peombwa commented May 19, 2022

OData actions bound to base types are being applied to derived types resolved via OData casting. From my testing, calling an action from an OData cast-derived type is not supported by the service e.g.,
MicrosoftTeams-image

This seems to occur even with ExpandDerivedTypesNavigationProperties = false.

Related to microsoftgraph/microsoft-graph-devx-api#1000.

Assemblies affected

1.0.10

@darrelmiller
Copy link
Member

@irvinesunday Is there a setting to disable generating actions on derived types that is independent to the ExpandDerivedTypesNavigationProperties?

@irvinesunday
Copy link
Collaborator

@irvinesunday Is there a setting to disable generating actions on derived types that is independent to the ExpandDerivedTypesNavigationProperties?

@darrelmiller, no we don't have such a setting.
Despite not being applicable in the Graph service, are actions on derived types allowable in OData?

@irvinesunday irvinesunday self-assigned this May 25, 2022
@CarolKigoonya CarolKigoonya added this to the 1.0.11 milestone May 25, 2022
@maisarissi
Copy link

maisarissi commented May 25, 2022

Hey folks. This is blocking us from releasing PowerShell SDK, and I saw that this issue was added into the 1.0.11 milestone, instead of being prioritized as part of 1.0.10 release. Is that right?
Please, can you reevaluate this? @CarolKigoonya @irvinesunday @darrelmiller

@irvinesunday irvinesunday added the priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days label May 26, 2022
@irvinesunday
Copy link
Collaborator

Hey folks. This is blocking us from releasing PowerShell SDK, and I saw that this issue was added into the 1.0.11 milestone, instead of being prioritized as part of 1.0.10 release. Is that right? Please, can you reevaluate this? @CarolKigoonya @irvinesunday @darrelmiller

The fix will go out in 1.0.11-preview1. I've labelled it as a p1

@maisarissi
Copy link

When is the release date for 1.0.11? Per my understanding, we are getting close to release the 1.0.10 version and update DevX API to use it, but until we get this fixed, the PowerShell SDK can't be generated.
We have added this item as part of our 1.0.10 tracking working on PS side: microsoftgraph/msgraph-sdk-powershell#1265

@irvinesunday
Copy link
Collaborator

@maisarissi v1.0.10 was released and DevX API is currently on this version. v1.0.11-preview1 is the next candidate and is scheduled to go out with the end of milestone 1.0.11; however, I am fast-tracking this so that we can release it by next week.

@maisarissi
Copy link

Thanks for the additional details @irvinesunday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants