Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Accent missing characters in 0.74.0 #28785

Closed
Arzza opened this issue Sep 27, 2023 · 18 comments
Closed

Quick Accent missing characters in 0.74.0 #28785

Arzza opened this issue Sep 27, 2023 · 18 comments
Assignees
Labels
Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Status-Reproducible This issue was reproduced by a maintainer

Comments

@Arzza
Copy link

Arzza commented Sep 27, 2023

Microsoft PowerToys version

0.74.0

Installation method

PowerToys auto-update

Running as admin

Yes

Area(s) with issue?

Quick Accent

Steps to reproduce

Attempt to enter a Greek character like alpha by holding a and using left/right keys but alpha is not listed. Attempt to set characters to only Greek, Greek not listed in character set drop down.

image

PowerToysReport_2023-09-27-13-15-21.zip

✔️ Expected Behavior

Greek characters to appear in toolbars

❌ Actual Behavior

Greek characters missing

Other Software

No response

@Arzza Arzza added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Sep 27, 2023
@crutkas
Copy link
Member

crutkas commented Sep 27, 2023

This is .73. No greek
image

@Arzza
Copy link
Author

Arzza commented Sep 27, 2023

Definitely had Greek symbols in the toolbars prior to updating. Also, the times sign is also missing from the toolbar for x (which also definitely had xi). Not sure if it's related, but I'm seeing a lot more Hebrew symbols than I did before.

@Arzza
Copy link
Author

Arzza commented Sep 27, 2023

This is from 0.73.0
image

This is from 0.74.0
image

@crutkas
Copy link
Member

crutkas commented Sep 27, 2023

@crutkas
Copy link
Member

crutkas commented Sep 27, 2023

languages.cs also should have the union run through maybe something like

in private static string[] GetDefaultLetterKeyALL(LetterKey letter),
Loop the Enum Language and call GetDefaultLetterKey and cache the result maybe?

GetDefaultLetterKey would throw a failure instantly if we passed in a language not in the loop

stackoverflow showed something ala this:
public static List GetEnumList() where TEnum : Enum
=> ((TEnum[])Enum.GetValues(typeof(TEnum))).ToList();

@crutkas
Copy link
Member

crutkas commented Sep 27, 2023

we should validate what actual items are MIA now from the older list too

@jaimecbernardo jaimecbernardo added Status-Reproducible This issue was reproduced by a maintainer Hot Fix Items we will product an out-of-band release for and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Sep 27, 2023
@jaimecbernardo
Copy link
Collaborator

This was my bad for not checking in https://github.com/microsoft/PowerToys/pull/28164/files if all characters that were in "All languages" were actually in any of the singular languages.

@jaimecbernardo jaimecbernardo self-assigned this Sep 27, 2023
@jaimecbernardo jaimecbernardo changed the title Quick Accent missing Greek characters Quick Accent missing characters in 0.74.0 Sep 27, 2023
@htcfreek
Copy link
Collaborator

htcfreek commented Sep 27, 2023

Do we have a Greek language again after the hotfix and can I select ot in settings?

@firta4
Copy link

firta4 commented Sep 27, 2023

Will this fix also bring back dashes such as "hyphen", "figure dash", "em dash", "horizontal bar", etc. to the hyphen-minus key? Currently in v0.74.0 it seems only "en dash" and "Hebrew punctuation maqaf" are left.

@AdNarayan07
Copy link

May I also request ± and ∓ signs for "-" or "+" keys.
And also include numpad buttons in quick accent.
And probably other mathematical symbols such as square and cube roots, degree, etc.

@jaimecbernardo
Copy link
Collaborator

We don't have a Greek language. What I fixed in #28802 was setting the characters that were missing in All languages again.

@jaimecbernardo jaimecbernardo added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Sep 28, 2023
@Kenya-West
Copy link

Kenya-West commented Sep 28, 2023

As I mentioned in #28847:

There's also fewer symbols when you press period (.) key. I used this key to set U+0301 symbol.....

image

That symbol list contained 10+ options but after 0.74.0 update it is now unusable for me as it does not contain U+301 symbol.

I need to clarify that my issue happens on ENG(US) + RUS(RU) keyboard layouts (whichever locale is on)

@jaminnash
Copy link

As a previous comment suggested, adding "±" to the "+" would be an excellent addition. Additionally, "≥" should be added under ">". "~", "≈", "≠", and "≡" should all be added under "=".

@Arzza
Copy link
Author

Arzza commented Sep 28, 2023

Additionally as per #27966 Add the degrees sign ° to either 0 or O accent lists

@EleKtr1X
Copy link

EleKtr1X commented Oct 1, 2023

The superscript minus () and the subscript minus () are also both missing from the comma key

@jaimecbernardo
Copy link
Collaborator

This has been fixed in 0.74.1. Please update PowerToys to the latest: https://github.com/microsoft/PowerToys/releases

@Kenya-West
Copy link

@jaimecbernardo can confirm, U+0301 made its way back to period . button! Thanks!

@jaimecbernardo
Copy link
Collaborator

The work associated with this issue has been released as part of the 0.75 sprint. Please update PowerToys to the latest. https://github.com/microsoft/PowerToys/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Status-Reproducible This issue was reproduced by a maintainer
Projects
None yet
Development

No branches or pull requests

9 participants