[Fixed in 0.75.1] PluginAdditionalOption.TextValue and other value properties are not persistent

[htcfreek]

Is it me or PluginAdditionalOption.TextValue and other value properties added in this PR are not persistent?

I think defaultOption.TextValue = option.TextValue; and other assigments are missing.

// SettingsReader.cs

private static IEnumerable<PluginAdditionalOption> CombineAdditionalOptions(IEnumerable<PluginAdditionalOption> defaultAdditionalOptions, IEnumerable<PluginAdditionalOption> additionalOptions)
        {
            var defaultOptions = defaultAdditionalOptions.ToDictionary(x => x.Key);
            foreach (var option in additionalOptions)
            {
                if (option.Key != null && defaultOptions.TryGetValue(option.Key, out PluginAdditionalOption defaultOption))
                {
                    defaultOption.Value = option.Value;
                    // should add other value properties here
                }
            }

            return defaultOptions.Values;
        }

Originally posted by @waaverecords in #28601 (comment)

[htcfreek]

@waaverecords
Can you please provide a poc of how to run into this bug.

[waaverecords]

Yes! @htcfreek

public class Main : IPlugin, ISettingProvider
{
    // ...

    IEnumerable<PluginAdditionalOption> ISettingProvider.AdditionalOptions => new List<PluginAdditionalOption>()
    {
        new PluginAdditionalOption
        {
            Key = "Textbox",
            DisplayLabel = "Textbox",
            PluginOptionType = PluginAdditionalOption.AdditionalOptionType.Textbox
        },
        new PluginAdditionalOption
        {
            Key = "Bool",
            DisplayLabel = "Bool"
            // PluginOptionType is Checkbox by default
        }
    };
}

Change the value of both settings.
Close PowerToys.
Open PowerToys.

Only the "Bool" option has its value persisted.
"Textbox" value is back to null.

[htcfreek]

@lin-ycv
I am sure this is the bug you hit with your initial settings implementation.

[lin-ycv]

Yes, sounds like the same issue.
I didn't look too deep into it, basically just changed all the setting properties to public and use load to read the values.

[waaverecords]

Pretty sure only SettingsReader.CombineAdditionalOptions needs modifications.
I'll look into it and make a PR if it's the case.

[htcfreek]

Pretty sure only SettingsReader.CombineAdditionalOptions needs modifications.
I'll look into it and make a PR if it's the case.

@waaverecords
Great. Then I will change assignment to you.

[waaverecords]

PR request -> #29480

[htcfreek]

@jaimecbernardo
As the 0.75.0 release is feature closed I think we can consider to include this issue in a hot fix if we have one.

[htcfreek]

@jaimecbernardo
I have added the "Hot Fix" label. Hope you are okay with doing that.