Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript Bot Sync Is Broken #39869

Closed
DanielRosenwasser opened this issue Aug 3, 2020 · 5 comments
Closed

TypeScript Bot Sync Is Broken #39869

DanielRosenwasser opened this issue Aug 3, 2020 · 5 comments
Assignees
Labels
Bug A bug in TypeScript Infrastructure Issue relates to TypeScript team infrastructure

Comments

@DanielRosenwasser
Copy link
Member

#38510 (comment)

https://github.com/microsoft/TypeScript/runs/939136680?check_suite_focus=true

Run git config user.email "ts_bot@rcavanaugh.com"
  git config user.email "ts_bot@rcavanaugh.com"
  git config user.name "TypeScript Bot"
  git fetch origin master
  git merge master --no-ff
  npm install
  npm test
  git push
  shell: /bin/bash -e {0}
From https://github.com/microsoft/TypeScript
 * branch              master     -> FETCH_HEAD
 * [new branch]        master     -> origin/master
merge: master - not something we can merge

Did you mean this?
	origin/master
@DanielRosenwasser DanielRosenwasser added Bug A bug in TypeScript Infrastructure Issue relates to TypeScript team infrastructure labels Aug 3, 2020
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 4.1.0 milestone Aug 3, 2020
@orta
Copy link
Contributor

orta commented Aug 5, 2020

Could be using the checkout action which doesn't grab history

@DanielRosenwasser
Copy link
Member Author

Just switching to merging from origin/master would do it though, right?

@weswigham
Copy link
Member

It needs a fetch command now, to get the ref.

@weswigham
Copy link
Member

But moreover, I probably wanna change it to actually delete the branch, then rebranch master, reset the version, and re-lkg; so none of this merge conflict malarkey happens when people cherry pick before they were supposed to.

@weswigham
Copy link
Member

weswigham commented Aug 13, 2020

I added a workflow trigger (so you can trigger it from the GH UI, in addition to from the bot), and updated it to fix the issue - it just wanted the incoming branch ref to be named origin/master instead of master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants