Static getters / setters can have incorrect this binding

[matthewjh]

class Base {
  static getCorrectFoo(): any {
     return this;
  }

   static get foo(): any {
      return this;
   }
}

class Inherited extends Base {}

Base.foo === Base;
Base.getCorrectFoo() === Base;

Inherited.foo === Base; /// Should be `Inherited`
Inherited.getCorrectFoo() === Inherited;

I believe this is because the foo getter will be defined via Object.defineProperty(Base, {..}), which hard-wires this to Base within the getter, rather than binding as expected to Inherited in Inherited.foo.

[matthewjh]

I have a fix in #4328, I just need some advice on testing it. Please take a look.

[DanielRosenwasser]

This is actually a duplicate of #1520. See http://typescript.codeplex.com/workitem/2324 for the rationale/workaround, and as @danquirk mentions on #1868 (comment), I don't think we've changed our position on it.

[matthewjh]

OK, so I'll (continue to) use my custom __extends so that my code functions as expected. Feels dirty as hell that I should have to do that, though.

Thanks Daniel!