Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS Server Performance Analysis Tooling #49006

Closed
DanielRosenwasser opened this issue May 6, 2022 · 2 comments
Closed

TS Server Performance Analysis Tooling #49006

DanielRosenwasser opened this issue May 6, 2022 · 2 comments
Assignees
Labels
Domain: Performance Reports of unusually slow behavior Infrastructure Issue relates to TypeScript team infrastructure

Comments

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented May 6, 2022

We have a performance suite of code where we can test out the full build time of individual projects; however, this performance suite is limited to just the compiler. It doesn't give a sense of work being done in the language service (e.g. the amount of work auto-imports might perform, or multi-project workspace loading might involve, time for find-all-reference, etc.). We need to be able to accurately measure these things.

We want to create a tool to run language service operations and report back on them to discover regressions in performance. We've done similar things on Definitely Typed, but we need other codebases to be run as well. Things to think about:

  • When and how do these tests run?
  • How does a person kick off these tests for a PR?
  • Where can we see the results of these tests if they're kicked off manually? If they're kicked off periodically?
  • Can we see time series records of the data?
  • Are operations consistent, or randomly applied?
  • What counts as an anomaly?
@DanielRosenwasser DanielRosenwasser added Infrastructure Issue relates to TypeScript team infrastructure Domain: Performance Reports of unusually slow behavior labels May 6, 2022
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 4.8.0 milestone May 7, 2022
@amcasey
Copy link
Member

amcasey commented May 10, 2022

  • When and how do these tests run?

Part of @typescript-bot perf test this

  • How does a person kick off these tests for a PR?

As above

  • Where can we see the results of these tests if they're kicked off manually? If they're kicked off periodically?

As above and maybe a dashboard like the one for tsc.

  • Can we see time series records of the data?

Yes, if we build out a dashboard.

  • Are operations consistent, or randomly applied?

Consistent - we need this to be repeatable. Random might follow later.

  • What counts as an anomaly?

We'll have to see how stable it ends up being, but I'm guessing it'll be as for tsc - anything over 1% is worth digging into, but may be acceptable if we're getting something for it.

@DanielRosenwasser
Copy link
Member Author

Seems fair to say this was done, right? Looks like the server perf tests are working pretty well so far!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domain: Performance Reports of unusually slow behavior Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants