Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dts): JsxSpreadAttribute - remove name from types #54599

Merged
merged 2 commits into from
Jun 21, 2023
Merged

fix(dts): JsxSpreadAttribute - remove name from types #54599

merged 2 commits into from
Jun 21, 2023

Conversation

dsherret
Copy link
Contributor

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jun 10, 2023
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

jakebailey
jakebailey approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely looks like an oops to me; the property is unused and not present in the factory functions. Probably this should be backported so people don't try and do something with it.

@DanielRosenwasser

@jakebailey jakebailey added this to the TypeScript 5.1.4 milestone Jun 13, 2023
@DanielRosenwasser DanielRosenwasser merged commit b5adef5 into microsoft:main Jun 21, 2023
@DanielRosenwasser DanielRosenwasser added the Breaking Change Would introduce errors in existing code label Jun 21, 2023
@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-5.1

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 21, 2023 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-5.1 on this PR at 08d2d73. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Jun 21, 2023
Merged
@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #54720 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Jun 21, 2023
@dsherret @typescript-bot
Cherry-pick PR microsoft#54599 into release-5.1
8acfb46 
Component commits:
297b647 fix(dts): `JsxSpreadAttribute` - remove `name` from types

08d2d73 Accept declaration changes
DanielRosenwasser pushed a commit that referenced this pull request Jun 26, 2023
@dsherret
🤖 Pick PR #54599 (fix(dts): JsxSpreadAttribute - re...) into releas…
2faa176 
…e-5.1 (#54720)

Co-authored-by: David Sherret <dsherret@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

@gabritto gabritto gabritto approved these changes

@weswigham weswigham Awaiting requested review from weswigham

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees
No one assigned
Labels
Breaking Change Would introduce errors in existing code For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
TypeScript 5.1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@dsherret @typescript-bot @DanielRosenwasser @jakebailey @gabritto