Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ViewModels, Views to reduce redundancy #627

Open
1 of 3 tasks
dipeshmsft opened this issue Aug 26, 2024 · 0 comments · Fixed by #624
Open
1 of 3 tasks

Refactor ViewModels, Views to reduce redundancy #627

dipeshmsft opened this issue Aug 26, 2024 · 0 comments · Fixed by #624

Comments

@dipeshmsft
Copy link
Member

dipeshmsft commented Aug 26, 2024

Description

The ask here is to reduce redundancy in the application code. Here are the few areas that can be made better :

  • Reduce redundancy in ViewModels : Most of the ViewModels, contain at least two members, title and description. Above that, the group pages consist of one more item - navigation cards / items. We can make a BasePageViewModel and BaseGroupPageViewModel which will consist of these common members and rest of the view models can inherit these and then provide there own members required for the pages
  • Reduce redundancy in Views : As of now, although we have seperate pages for each group, however the view for each of these pages is exactly the same. Moreover, the structure of their view models are also the same. Find a way to combine all of these into a single page with different data populated
  • Remove excess imports : Currently all the C# files import the required namespaces, and are not utilizing the global using feature of C#. Add the common namespaces in Usings.cs and remove the respective namespaces from the files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant