Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emoji support to Windows Console #590

Closed
bitcrazed opened this issue Jun 27, 2016 · 20 comments
Closed

Add emoji support to Windows Console #590

bitcrazed opened this issue Jun 27, 2016 · 20 comments
Assignees
Labels

Comments

@bitcrazed
Copy link
Contributor

Windows Console does not support emoji and other extended character-sets, as reported by the emoj team: sindresorhus/emoj#5 (comment)

Consider adding emoji support to Windows Console in the future

@MadcowD
Copy link

MadcowD commented Jun 29, 2016

Come on; at least give us GPU support first.

@be5invis
Copy link

be5invis commented Aug 3, 2016

@bitcrazed
Are you going to rewrite the entire CONHOST and console C/C++ API?
Gee...

@bitcrazed
Copy link
Contributor Author

@be5invis Rewrite? Only the parts that desperately need it. Otherwise, we're re-architecting and modularizing much of the Console internals which will result in us being able to iterate FAR faster, and more confidently & safely.

@sandhilt
Copy link

Make console great again.

@jackchammons jackchammons removed the bug label Apr 11, 2017
@fcharlie
Copy link

fcharlie commented Jun 7, 2017

Is there any progress in supporting emoji ?

@be5invis
Copy link

be5invis commented Jun 7, 2017

@fcharlie This is very hard, the entire console buffer is a fixed data structure that each cell has only 16 bits.

@be5invis
Copy link

be5invis commented Jun 7, 2017

@fcharlie And it has C++ interfaces...
Means that we cannot change that.

@fcharlie
Copy link

fcharlie commented Jun 9, 2017

@be5invis I use WriteConsoleW output emoji ❤️ ,mybe use DirectWrite can output more Emoji

wsudo

@coreh
Copy link

coreh commented Nov 4, 2017

Not entirely sure on the internals, but it should be possible to affect only the rendering, without changing the underlying memory structure. (Even if the character spacing becomes "off" with emoji taking up the space of two regular characters, that would be a fine compromise)

@bitcrazed
Copy link
Contributor Author

'it should be possible to affect only the rendering, without changing the underlying memory structure'

Sure ... if you're starting from scratch, you might chose some flexible encoding like UTF-8 (though that has it's own perf costs to consider), but doesn't help you when the Console's internal buffers are currently UCS-2 based and can't fully deal with Unicode scenarios including zero-width joiners, and surrogate pairs.

And in amongst the work to handle Unicode encodings that we don't currently support (e.g. UTF-8), we have to modularize and wrap the internal buffers, expose an API that the rest of the Console is modified to call, rather than allowing external code to delve into the data structures and directly manipulate memory in a somewhat haphazard manner!

@HotelCalifornia
Copy link

I hate to be that guy, but have there been any updates to this?

@bitcrazed
Copy link
Contributor Author

@HotelCalifornia - You are now, officially, THAT guy ;) :D

While we've not moved forward on this feature of late, we HAVE completed a ton of stuff & this ask is edging up the backlog.

A few more things to get to yet, but it's getting closer.

Bear with us!

@stereokai
Copy link

@bitcrazed thanks for the honest update. Does that mean UTF-8 is also on the way?

@bitcrazed
Copy link
Contributor Author

Absolutely. UTF-8 support is a pre-req' for us to eventually support emoji, and many other complex languages, symbols, etc.

@bitcrazed
Copy link
Contributor Author

Thanks for the discussion.

Closing this issue since:

  1. As noted above, we've a long list of work items that'll enable Console to store and render MUCH more of the UNICODE glyph space. It'll take us a while to get through them, but the work has begun
  2. This is the WSL issues repo, but this is an issue in Console which has its own Console GitHub Repo
  3. GitHub doesn't allow issues to be moved between repos, preserving posters' identity :(

If you have further asks/issues, please file new issues on our Console GitHub Repo.

@HLFH
Copy link

HLFH commented May 23, 2018

Ok @bitcrazed

Go here: microsoft/terminal#190

@lucharo
Copy link

lucharo commented Nov 12, 2020

None of these options are working for me. When I try to run any variant of wsl --set-version Ubuntu 1 I get:

Error: Oxffffffff

@bitcrazed
Copy link
Contributor Author

Sorry @lc5415 - this is the Terminal repo, and a closed issue discussing emoji support.

If you're having WSL issues, could you please file an issue on the WSL repo: https://github.com/microsoft/wsl. Thanks.

@lucharo
Copy link

lucharo commented Nov 12, 2020

Excuse me @bitcrazed I got the issue number wrong!

@bitcrazed
Copy link
Contributor Author

No problem ... I've done this countless times myself ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests