Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRTCore] In a packaged win32 app, the PRI is placed one directory above the EXE. #528

Closed
rohanp-msft opened this issue Mar 5, 2021 · 2 comments
Assignees

Comments

@rohanp-msft
Copy link
Contributor

rohanp-msft commented Mar 5, 2021

Quoting Hui on the problem this presents:
"Not in the same folder, the app doesn’t know what resource file to use. MRTCore doesn’t support “..\resources.pri”."

This is a possible customer scenario. Quoting Hui:
"A customer may have an app, then decide to package it."

BTW, it is as of yet unknown if this issue exists only when the to-be-packaged win32 app project is "external".
We suspect it is though because of this: WinUI solutions are also WAP projects and they don't have this issue. In that case though, the .vcxproj/.csproj project isn't external.

@rohanp-msft rohanp-msft self-assigned this Mar 5, 2021
@ghost ghost added the needs-triage label Mar 5, 2021
@rohanp-msft rohanp-msft changed the title If a WAP project references an external win32 app .vcxproj, the PRI is placed one directory above the EXE. [MRTCore] If a WAP project references an external win32 app .vcxproj, the PRI is placed one directory above the EXE. Mar 5, 2021
@rohanp-msft rohanp-msft changed the title [MRTCore] If a WAP project references an external win32 app .vcxproj, the PRI is placed one directory above the EXE. [MRTCore] In a packaged win32 app, the PRI is placed one directory above the EXE. Mar 5, 2021
@sylveon
Copy link

sylveon commented Apr 25, 2021

Might be fixed by something like this?

https://github.com/microsoft/terminal/blob/3d09c7de1b35ce3593efb8185df98c47302c1050/src/cascadia/CascadiaPackage/CascadiaPackage.wapproj#L85-L87

I think, generally, this decision of putting every project in its own folder for MSIX packaging should be reconsidered, or made an option, considering normal VS output puts all artifacts in the same folder but the .wapproj does not. This means many common scenarios (a .exe with an associated .dll for example) break by default with .wapproj.

@rohanp-msft
Copy link
Contributor Author

This has been fixed already by:
#814
and
#908
So closing this issue.

@sylveon As of the v1.0 preview releases, we've added single-project MSIX support. Please see https://docs.microsoft.com/en-us/windows/apps/windows-app-sdk/single-project-msix?tabs=csharp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants