Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing fields on git.IdentityRefWithVote #53

Closed
bvwells opened this issue Mar 9, 2020 · 8 comments
Closed

Missing fields on git.IdentityRefWithVote #53

bvwells opened this issue Mar 9, 2020 · 8 comments
Labels
bug Something isn't working

Comments

@bvwells
Copy link
Contributor

bvwells commented Mar 9, 2020

The model git.IdentityRefWithVote defined here

type IdentityRefWithVote struct {

is missing various fields. For reference,

https://docs.microsoft.com/en-us/rest/api/azure/devops/git/pull%20request%20reviewers/create%20pull%20request%20reviewer?view=azure-devops-rest-5.1#identityrefwithvote

It would be great if the models could be updated to add these missing fields.

@bvwells
Copy link
Contributor Author

bvwells commented Mar 9, 2020

Was thinking of raising a PR, but I guess https://github.com/microsoft/azure-devops-go-api/blob/dev/azuredevops/git/models.go is auto-generated...

@tedchamb tedchamb added the bug Something isn't working label Mar 10, 2020
@tedchamb
Copy link
Member

Yeah the model code is auto-generated, so any fix needs to be made on the code generator. I'll have a look when I get a chance.

@tmeckel
Copy link
Contributor

tmeckel commented Mar 11, 2020

@tedchamb same with my bug #47 would be great if you could fix that at the same time

@tedchamb
Copy link
Member

@bvwells , thanks for reporting this issue. It has been fixed in PR #66, and is in the following release:

https://github.com/microsoft/azure-devops-go-api/releases/tag/azuredevops%2Fv5.1.0-b1

@bvwells
Copy link
Contributor Author

bvwells commented May 17, 2020

Thanks, I'll give it a go. I suspect the v5 tag will cause an issue as the go module is not defined as v5...

@tedchamb
Copy link
Member

@bvwells , thanks for the heads up on the v5 issue. I will fix this. Still not used to all the go module rules.

@tedchamb
Copy link
Member

I added a new release under v1, while i fix the v5 issue:
https://github.com/microsoft/azure-devops-go-api/releases/tag/azuredevops%2Fv1.0.0-b2

@bvwells
Copy link
Contributor Author

bvwells commented May 18, 2020

Thanks @tedchamb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants