-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automaticLayout broken on master? #1855
Comments
It is possible that microsoft/vscode#90111 has broken things. On Do you have a pointer to the outer code? |
The code is a little complex because there's a few moving parts...
Monaco lives in a |
Aha! I believe this is due to the usage of So the height of the container can change without any properties being changed... The |
Nice sleuthing, I'm open to this issue being closed - I'm not really sure what else you could do from Monaco's side for something like this other than have an optional fallback to the old mode |
Well, I think we're using the wrong concept. I just found https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserver |
Resize Observer is the best way to do it, but lacks Safari support and I think at the time Monaco was still supporting IE, which also doesn’t support Resize Observer. |
See #1884 for another issue that seems to be related to |
I’ll try to get a PR submitted this weekend to work as described above. |
Any chance for a new bugfix release including the fix above? |
Repro:
3.7.5 is from about a month ago, 3.8.3 is from yesterday.
They both have the same outer code for the playground, but refer to different Monaco-editors and Monaco TypeScripts. I'll know I can move off
automaticLayout
by telling the editor when the sidebar changes, but I'll leave it this way for a few days so there's a a working repro.The text was updated successfully, but these errors were encountered: