Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Security vulnerability in DOMPurify@3.0.5 (used by VSCode & Monaco) #4692

Open
2 tasks done
aleixsuau opened this issue Sep 20, 2024 · 2 comments
Open
2 tasks done
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@aleixsuau
Copy link

aleixsuau commented Sep 20, 2024

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Monaco Editor Playground Link

No response

Monaco Editor Playground Code

No response

Reproduction Steps

No response

Actual (Problematic) Behavior

Our OWASP scan detected an issue in DOMPurify@3.0.5 CVE-2024-45801 which seems to be used by the Monaco editor (VSCode): https://github.com/microsoft/vscode/blob/main/src/vs/base/browser/dompurify/dompurify.js

Please update to DOMPurify@3.1.3 to get rid of that vulnerability.

Thanks

Expected Behavior

There should be no vulnerability issues.

Additional Context

No response

@jshawl
Copy link

jshawl commented Sep 20, 2024

It looks like DOMPurify was bumped here https://github.com/microsoft/vscode/pull/228773/files but not yet vendored like in this other DOMPurify bump PR - https://github.com/microsoft/vscode/pull/189368/files

@jasonparallel
Copy link

@rzhao271 Just wanted to at you as you merged in the version update for DOMPurify

@rzhao271 rzhao271 self-assigned this Sep 24, 2024
@rzhao271 rzhao271 added this to the September 2024 milestone Sep 24, 2024
@rzhao271 rzhao271 added the bug Issue identified by VS Code Team member as probable bug label Sep 25, 2024
@rzhao271 rzhao271 modified the milestones: September 2024, October 2024 Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

5 participants