Syntax Error when running local_o365\task\usersync

[peta3000]

Hi @weilai-irl
When running the usersync script a client receives the following syntax-error:

Context:
database: postgres
moodle-version: 4.0.4
local_o365 version: 2022041905 (current master branch, 4.0.1 release)

According to the syntax of the "JOIN" clause the "ON" condition seems to be optional in MySQL but expected in other database-types:
here a reference discussion on stackoverflow:
https://stackoverflow.com/questions/16470942/how-to-use-mysql-join-without-on-condition

the problematic sql-query seems to be at the end of this php-file:
https://github.com/microsoft/o365-moodle/blob/MOODLE_40_STABLE/local/o365/lib.php

Has there already been a patch in the meanwhile?

Thanks a lot!
With best regards!

peta3000

related issue(s):
#2173

[weilai-irl]

Hi @peta3000,

I have updated the code change fixing the linked issue #2173 to cater for this issue as well. You can try it out in your environment. The fix will be included in the next release.

Regards,
Lai

[peta3000]

Dear @weilai-irl
Thanks a lot for your reply!
We are going to wait for the next release then :)

Many thanks and best regards

peta

[weilai-irl]

Hi all,

The fix to this issue has been included in the release from today. Please upgrade your plugins to the latest version to see the changes.

I'm going to close the issue now.

Regards,
Lai

[peta3000]

Thanks a lot for your efforts @weilai-irl !!!

Looking forward to giving it a try! :)
Best regards
peta