Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Skipped tests mark as failed #18544

Closed
judithhartmann opened this issue Nov 3, 2022 · 1 comment
Closed

[Question] Skipped tests mark as failed #18544

judithhartmann opened this issue Nov 3, 2022 · 1 comment

Comments

@judithhartmann
Copy link

judithhartmann commented Nov 3, 2022

Hey,
we have some tests that we skip conditionally, therefore the beforeEach and the beforeAll are run before these tests.
If playwright detects an error in these steps, it will fail this test. So far so good.

We have retries enabled, so when the retry of the test makes it to the test.skip it skips the test
In the end the test is marked as FAILED in the final results, even though it was 1 failure run, 1 skip run (success kinda).
Is this the desired behaviour? I feel like it should be marked as skipped.

@aslushnikov
Copy link
Contributor

This is a dupe of #17652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants