Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent suggest current writing name on renaming existed variable. #2189

Closed
byehack opened this issue Dec 22, 2021 · 6 comments
Closed

Prevent suggest current writing name on renaming existed variable. #2189

byehack opened this issue Dec 22, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@byehack
Copy link

byehack commented Dec 22, 2021

Rec.0063.mp4

I don't want receive new name suggestion in list.

@heejaechang
Copy link
Contributor

I think current behavior is correct since we don't know whether user intent to use "." off existing variable or not.

ex) rec.denominator = 1

@heejaechang heejaechang removed the triage label Jan 3, 2022
@github-actions github-actions bot added the triage label Jan 3, 2022
@judej judej added the waiting for user response Requires more information from user label Jan 4, 2022
@github-actions github-actions bot removed the triage label Jan 4, 2022
@byehack
Copy link
Author

byehack commented Jan 22, 2022

I think current behavior is correct since we don't know whether user intent to use "." off existing variable or not.

ex) rec.denominator = 1

but there is no rec defined before. so rec.denominator = 1 would not be correct.

@debonte debonte removed the waiting for user response Requires more information from user label Jan 24, 2022
@heejaechang
Copy link
Contributor

heejaechang commented Jan 24, 2022

are you saying we should not show the variable itself in the completion? well, we could do that but not sure how high priority it is.

I looked other languages to see whether they do such thing (since it will require bunch of fine grind semantic checks). I looked TS and C# and both behave same as us.

image

image

anyway, let us put it in the back log.

...

you could still argue that python doesn't require variable to be explicitly defined before so, it is different than TS and C#. but still not sure whether it is high priority.

@debonte debonte added the enhancement New feature or request label Jan 24, 2022
@github-actions github-actions bot removed the triage label Jan 24, 2022
@byehack
Copy link
Author

byehack commented Jan 25, 2022

are you saying we should not show the variable itself in the completion?

prevent show suggestion only when refactor/rename existed names:

image

we shouldn't see this suggest.

1 similar comment
@byehack
Copy link
Author

byehack commented Jan 25, 2022

are you saying we should not show the variable itself in the completion?

prevent show suggestion only when refactor/rename existed names:

image

we shouldn't see this suggest.

@heejaechang heejaechang self-assigned this Mar 23, 2022
@heejaechang heejaechang added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label Mar 24, 2022
@bschnurr
Copy link
Member

This issue has been fixed in version 2022.3.4, which we've just released. You can find the changelog here: CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

5 participants