Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show class hierarchy or method override like pycharm #4972

Open
yiciu opened this issue Feb 19, 2022 · 21 comments
Open

show class hierarchy or method override like pycharm #4972

yiciu opened this issue Feb 19, 2022 · 21 comments
Assignees

Comments

@yiciu
Copy link

yiciu commented Feb 19, 2022

For now, we can't see at a glance which methods in the class override the methods of the parent class. Whether this function can be added in subsequent versions, as in pycharm, you can jump to the method in the overriding parent class through the icon to see.
image
image

@judej
Copy link
Contributor

judej commented Feb 22, 2022

Waiting for upvotes on this feature request

@judej judej transferred this issue from microsoft/pylance-release Feb 22, 2022
@luabud
Copy link
Member

luabud commented Feb 22, 2022

Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 7 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.

@brettcannon
Copy link
Member

Thank you to everyone who upvoted this issue! Since the community showed interest in this feature request we will leave this issue open as something to consider implementing at some point in the future.

We do encourage people to continue 👍 the first/opening comment as it helps us prioritize our work based on what the community seems to want the most.

@andrewellis55
Copy link

The title of this issue mentions a "Class Hierarchy" feature, however the text mostly discusses method overrides. I'm not sure if this issue will look into the Hierarchy portion as well, however here are some docs on the PyCharm Hierarchy features if so

https://www.jetbrains.com/help/pycharm/viewing-structure-and-hierarchy-of-the-source-code.html#ws_build_hierarchy

@ArkiZh
Copy link

ArkiZh commented Sep 21, 2022

Looking forward to this feature "View hierarchies conveniently".

This is a big reason why I am still using PyCharm as the main editor, since it's very convenient to analyze code structure while developing complex projects which usually contain complex class hierarchies.

I think this feature should contain:

  1. Prompt for class, method implementations by icons near line number. As @yiciu mentioned.
  2. Show the class hierarchy in a separate place. As @andrewellis55 mentioned.

@msouff
Copy link

msouff commented Oct 7, 2022

Just do it

@parijathakumar
Copy link

Very much interested in this feature. 👍 If an open poll is created, many would vote for it, I suppose. Though I've been waiting for this feature for long, it's only today that I found this issue, or bothered to find if this issue already exists or not.

@brettcannon
Copy link
Member

If an open poll is created

The poll is 👍 reactions on the first comment/OP.

@ArkiZh
Copy link

ArkiZh commented Feb 22, 2023

How is it going now?

@brettcannon
Copy link
Member

How is it going now?

As the "needs proposal" label indicates, at this point someone needs to come forward with a proposal on how to make this feature work, both from a UX and code perspective. As of right now this is the 11th most upvoted issue, so it's not at the top. You can also always check our iteration plan to see if something is scheduled to be worked on in the next month (this specific issue is not).

@mahes1287
Copy link

eagerly waiting for this feature

@pbasimfa
Copy link

pbasimfa commented Sep 6, 2023

This is really helpful if added. Saves time in repos with a deep class hierarchy (regardless of it being a bad practice)

@MilanHofmann
Copy link

Please add this feature!

@github-actions github-actions bot added the needs repro Issue has not been reproduced yet label Oct 17, 2023
@brettcannon brettcannon transferred this issue from microsoft/vscode-python Oct 17, 2023
@heejaechang heejaechang added triage-needed and removed needs repro Issue has not been reproduced yet labels Oct 17, 2023
@judej

This comment was marked as off-topic.

@judej

This comment was marked as off-topic.

@judej

This comment was marked as outdated.

@elskito

This comment was marked as outdated.

@debonte

This comment was marked as outdated.

@elskito
Copy link

elskito commented Apr 19, 2024

@elskito, I agree. Despite Jude's comment that he was closing the issue, it appears it was never closed. I'm going to hide our three comments to avoid future confusion. I appreciate you pointing this out.

Could you please tag this as well? It's been a while since the OP made a suggestion, and after checking other issues, this request has the most thumbs up. Any information about implementing this feature in future releases would also be wonderful :)

@rbli-john
Copy link

Eagerly waiting for this feature

@heejaechang
Copy link
Contributor

whether current method override a method or not is cheap, but finding out whether other classes overriding this method is expensive. that's why we are hesitant. but once we do full mode (#5434), we might put this feature under full mode since they opt-in to richer features at the expense of performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests