Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent use of '...' in UI labels #5218

Closed
mjbvz opened this issue Dec 6, 2023 · 2 comments
Closed

Inconsistent use of '...' in UI labels #5218

mjbvz opened this issue Dec 6, 2023 · 2 comments
Assignees
@heejaechang
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@mjbvz
Copy link

mjbvz commented Dec 6, 2023 •
edited
Loading

Type: Bug

Two quick things I notied with how ... is used in ui labels:

  • In move to file, ... should not be used for the section label (Destination files ...)

  • In a few places in the UX, the ... is has a space before it: Label .... I believe the convention is to omit the space: Label...

Image

Extension version: 2023.23.13391009
VS Code version: Code - Insiders 1.85.0-insider (Universal) (af28b32d7e553898b2a91af498b1fb666fdebe0c, 2023-12-06T11:18:22.866Z)
OS version: Darwin arm64 23.1.0
Modes:

System Info
Item Value
CPUs Apple M2 Max (12 x 24)
GPU Status 2d_canvas: unavailable_software
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: disabled_software
multiple_raster_threads: enabled_on
opengl: disabled_off
rasterization: disabled_software
raw_draw: disabled_off_ok
video_decode: disabled_software
video_encode: disabled_software
vulkan: disabled_off
webgl: unavailable_software
webgl2: unavailable_software
webgpu: unavailable_software
Load (avg) 3, 3, 3
Memory (System) 64.00GB (1.94GB free)
Process Argv --crash-reporter-id 0fffb5da-9cd7-46fd-9e7f-a1564e8c5fda
Screen Reader no
VM 0%
@mjbvz mjbvz changed the title Inconsistent use of '...' in UX labels Inconsistent use of '...' in UI labels Dec 6, 2023
@eleanorjboyd eleanorjboyd transferred this issue from microsoft/vscode-python Dec 6, 2023
@github-actions github-actions bot added the needs repro Issue has not been reproduced yet label Dec 6, 2023
@mjbvz
Copy link
Author

mjbvz commented Dec 6, 2023

Also Destination files should be lowercase to match our other separator labels: microsoft/vscode#200184

@heejaechang heejaechang added bug Something isn't working and removed needs repro Issue has not been reproduced yet labels Dec 15, 2023
@PylanceBot PylanceBot added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label Dec 18, 2023
@debonte
Copy link
Contributor

debonte commented Dec 21, 2023

This issue has been fixed in prerelease version 2023.12.101, which we've just released. You can find the changelog here: CHANGELOG.md

@debonte debonte closed this as completed Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heejaechang heejaechang

Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@heejaechang @debonte @mjbvz @eleanorjboyd @PylanceBot