Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings are not shown for non-overridable settings when a config file is present in a multi-root workspace scenario #6338

Closed
StellaHuang95 opened this issue Aug 30, 2024 · 2 comments
Closed

Warnings are not shown for non-overridable settings when a config file is present in a multi-root workspace scenario #6338

StellaHuang95 opened this issue Aug 30, 2024 · 2 comments
Assignees
@rchiodo
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@StellaHuang95
Copy link
Contributor

Environment data

  • Pylance version: 2024.8.104

Repro Steps

  1. Clone pylance-release
  2. Open the multi-root workspace testing/test.code-workspace in VS Code
  3. Open single\.vscode\settings.json

Expected behavior

Squiggles should appear on non-overridable settings, along with a "xxx cannot be set" warning.

Actual behavior

No warnings or squiggles
@github-actions github-actions bot added the needs repro Issue has not been reproduced yet label Aug 30, 2024
@rchiodo
Copy link
Contributor

rchiodo commented Aug 30, 2024

Might have something to do with this code here:
https://github.com/microsoft/pyrx/blob/f96e1447cd84cd54934e0c4499183f7cf1ccf39f/packages/vscode-pylance/src/providers/settingsJsonWatcher.ts#L70

Maybe it's not finding the workspace folder that matches the settings.json

@rchiodo rchiodo assigned rchiodo and unassigned bschnurr Aug 30, 2024
@rchiodo rchiodo added bug Something isn't working and removed needs repro Issue has not been reproduced yet labels Aug 30, 2024
@bschnurr bschnurr added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label Aug 30, 2024
@StellaHuang95 StellaHuang95 mentioned this issue Sep 11, 2024
Merged
@StellaHuang95
Copy link
Contributor Author

This issue has been fixed in prerelease version 2024.9.100, which we've just released. You can find the changelog here: CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rchiodo rchiodo

Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bschnurr @rchiodo @StellaHuang95