Issue6335 #6357
Merged
Issue6335 #6357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ize and parse a binary (native) library file. This led to a crash in some cases. This addresses microsoft/pylance-release#5090.
…ethod returns `Self` for a generic class and the type variable is invariant. This addresses #6335.
|
Diff from mypy_primer, showing the effect of this PR on open source code: bidict (https://github.com/jab/bidict)
- /tmp/mypy_primer/projects/bidict/bidict/_base.py
- /tmp/mypy_primer/projects/bidict/bidict/_base.py:203:24 - error: Cannot assign member "_invweak" for type "BidictBase[VT@BidictBase, KT@BidictBase]"
- Type "ref" cannot be assigned to type "ReferenceType[BidictBase[KT@BidictBase, VT@BidictBase]] | None"
- "ref" is incompatible with "ReferenceType[BidictBase[KT@BidictBase, VT@BidictBase]]"
- Type parameter "_T@ReferenceType" is invariant, but "Self@BidictBase[KT@BidictBase, VT@BidictBase]" is not the same as "BidictBase[KT@BidictBase, VT@BidictBase]"
- "ref" is incompatible with "None" (reportGeneralTypeIssues)
- 12 errors, 0 warnings, 0 informations
+ 11 errors, 0 warnings, 0 informations
Tanjun (https://github.com/FasterSpeeding/Tanjun)
- /tmp/mypy_primer/projects/Tanjun/tanjun/clients.py:2271:27 - warning: Argument type is partially unknown
- Argument corresponds to parameter "__function" in function "__new__"
- Argument type is "(c: MenuCommand[Any, Unknown]) -> bool" (reportUnknownArgumentType)
- /tmp/mypy_primer/projects/Tanjun/tanjun/clients.py:2271:20 - warning: Return type, "filter[MenuCommand[Any, Unknown]]", is partially unknown (reportUnknownVariableType)
- /tmp/mypy_primer/projects/Tanjun/tanjun/clients.py:2271:34 - warning: Type of parameter "c" is partially unknown (reportUnknownLambdaType)
- 2344 errors, 10518 warnings, 0 informations
+ 2344 errors, 10515 warnings, 0 informations
antidote (https://github.com/Finistere/antidote)
- /tmp/mypy_primer/projects/antidote/src/antidote/core/_catalog.py:214:65 - error: Argument of type "ref" cannot be assigned to parameter "__catalog_ref" of type "ReferenceType[CatalogImpl]" in function "__init__"
- "ref" is incompatible with "ReferenceType[CatalogImpl]"
- Type parameter "_T@ReferenceType" is invariant, but "Self@CatalogImpl" is not the same as "CatalogImpl" (reportGeneralTypeIssues)
- 726 errors, 31 warnings, 0 informations
+ 725 errors, 31 warnings, 0 informations
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.