Skip to content
This repository has been archived by the owner on Apr 14, 2022. It is now read-only.

What does showAdvancedMembers mean? #1349

Closed
Jma353 opened this issue Jul 18, 2019 · 4 comments
Closed

What does showAdvancedMembers mean? #1349

Jma353 opened this issue Jul 18, 2019 · 4 comments

Comments

@Jma353
Copy link

Jma353 commented Jul 18, 2019

I noticed a setting called showAdvancedMembers when poking around to see what setting inputs the language server takes in to enable customization of a user's experience.

What does this setting mean? Is it still used, or is it a relic of some since-removed code (b/c I can't see it referred to anywhere).

@Jma353
Copy link
Author

Jma353 commented Jul 18, 2019

I guess I could ask similar questions about other settings that are passed into the language server (e.g. symbolsHierarchyDepthLimit) - where are these used? Github search isn't turning up many results for me - I only see defaults and the assignment of the variable. I guess, in general, I'm wondering what settings this language server now accepts to customize its inner-workings (analysis, caching, etc.) as well as user-experience things (e.g. autocomplete with parens, outline depth, etc.)

@jakebailey
Copy link
Member

All of those settings seem to be dead code and leftovers from the pre-rewrite language server. I believe showAdvancedMembers controlled when dunder methods would show. The symbols settings limited the symbol indexing (the outline, workspace search), but needed to move during the rewrite and instead get limited at request time rather than hardcoded.

There's a bunch of old setting cruft we could remove, just haven't had the time to yet.

@Jma353
Copy link
Author

Jma353 commented Jul 22, 2019

Nice - thanks for the answer!

Follow-up request: it would be great if there was up-to-date docs w.r.t. what options can be passed to this language server (I guess one could read the code, but still).

Closing as my original question was answered.

@Jma353 Jma353 closed this as completed Jul 22, 2019
@jakebailey
Copy link
Member

Yes, definitely. See also #469, #794, #1184, #1212, #1340. Our focus has been on getting things to work and fixing bugs, so docs and settings cleanups just haven't happened.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants