Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking] Endpoint routing with middleware #15

Closed
analogrelay opened this issue Mar 12, 2020 · 2 comments
Closed

[Tracking] Endpoint routing with middleware #15

analogrelay opened this issue Mar 12, 2020 · 2 comments
Labels
Type: Enhancement New feature or request
Milestone

Comments

@analogrelay
Copy link
Member

This will likely be useful for adding middleware to specific routes.
dotnet/aspnetcore#14514

The workaround today is creating your own app builder.
https://github.com/dotnet/proxy/commit/8be62673e25861e283c14aafcc60db2b0ed928b7#diff-a899554e36fdb9c1c365b48b296246cdR35-R37

@analogrelay analogrelay added the Type: Enhancement New feature or request label Mar 12, 2020
@analogrelay analogrelay changed the title Endpoint routing with middleware [Tracking] Endpoint routing with middleware Apr 13, 2020
@analogrelay analogrelay added this to the 1.0.0 milestone Apr 23, 2020
@Tratcher
Copy link
Member

Tratcher commented May 2, 2020

Per design decisions elsewhere, we don't need this work item anymore. We decided not to do custom pipelines for routes, but rather to have middleware inspect the route data at runtime and enable/disable themselves (which also works for hosts). The main trouble is that the proxy routes can be reloaded during the lifetime of the app, but pipelines are too complicated to define in config or rebuild every time the proxy config changes.

@karelz
Copy link
Member

karelz commented May 7, 2020

Closing as we don't need it.

@karelz karelz closed this as completed May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants