Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customized SocketsHttpHandler should not break distributed tracing #292

Closed
samsp-msft opened this issue Jul 2, 2020 · 8 comments
Closed
Assignees
Labels
Type: Tracking Tracking work to be done in other repositories.

Comments

@samsp-msft
Copy link
Contributor

dotnet/runtime#31261

@samsp-msft samsp-msft added Type: Tracking Tracking work to be done in other repositories. .NET runtime schedule labels Jul 2, 2020
@samsp-msft samsp-msft added this to the 1.0.0 milestone Jul 2, 2020
@cijothomas
Copy link

Is this issue created just to track the issue from runtime? Or any other workaround planned here? I wonder if it is even possible to have any workaround at all.

@Tratcher
Copy link
Member

Tratcher commented Jul 7, 2020

It's only for tracking so far. No workaround has been proposed.

@cijothomas
Copy link

It's only for tracking so far. No workaround has been proposed.

Thanks. We were following up internally and was wondering if anyone found workarounds.

@karelz
Copy link
Member

karelz commented Jul 28, 2020

Discussion with @samsp-msft: This is not solvable in 5.0 timeframe of .NET Core - hence removing the label ".NET runtime schedule".
YARP 1.0.0 should try to implement the workaround we recommend on main issue (keeping it in 1.0.0 milestone).

@Tratcher
Copy link
Member

@karelz would this be a good one for @MihaZupan?

@jmezach
Copy link
Contributor

jmezach commented Oct 6, 2020

We just ran into this issue which is a bit of a bummer because we were kinda expecting this to work out of the box. We have New Relic set up to monitor our environment but it is unable to correlate the requests going into YARP and onwards to the downstream service.

Is there something we can help out with?

@Tratcher
Copy link
Member

Tratcher commented Oct 6, 2020

If you'd like to experiment with the workarounds for YARP by all means. E.g. you could try copying the DiagnosticsHandler into YARP and wiring it up.

@MihaZupan
Copy link
Member

Fixed by #456

We exposed a new class ActivityPropagationHandler for injecting tracing headers based on the current activity.

It is used by the HttpInvoker factory by default, unless disabled by setting PropagateActivityContext to false explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Tracking Tracking work to be done in other repositories.
Projects
None yet
Development

No branches or pull requests

6 participants