-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customized SocketsHttpHandler should not break distributed tracing #292
Comments
Is this issue created just to track the issue from runtime? Or any other workaround planned here? I wonder if it is even possible to have any workaround at all. |
It's only for tracking so far. No workaround has been proposed. |
Thanks. We were following up internally and was wondering if anyone found workarounds. |
Discussion with @samsp-msft: This is not solvable in 5.0 timeframe of .NET Core - hence removing the label ".NET runtime schedule". |
@karelz would this be a good one for @MihaZupan? |
We just ran into this issue which is a bit of a bummer because we were kinda expecting this to work out of the box. We have New Relic set up to monitor our environment but it is unable to correlate the requests going into YARP and onwards to the downstream service. Is there something we can help out with? |
If you'd like to experiment with the workarounds for YARP by all means. E.g. you could try copying the DiagnosticsHandler into YARP and wiring it up. |
Fixed by #456 We exposed a new class It is used by the HttpInvoker factory by default, unless disabled by setting |
dotnet/runtime#31261
The text was updated successfully, but these errors were encountered: