Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] Example does not build with yarn #1024

Open
joerneu opened this issue Jan 12, 2019 · 3 comments
Open

[rush] Example does not build with yarn #1024

joerneu opened this issue Jan 12, 2019 · 3 comments
Labels
bug Something isn't working as intended effort: easy Probably a quick fix. Want to contribute? :-) help wanted If you're looking to contribute, this issue is a good place to start!

Comments

@joerneu
Copy link

joerneu commented Jan 12, 2019

The example does not build with yarn.

To reproduce:

  • Switch to yarn: (Set "yarnVersion": "1.13.0" in rush.json)
  • Delete pnpmfile.js from common/config/rush/
  • Run rush update --full --purge
  • Run rush rebuild

Error: "node_modules.bin\my-build" not found when building "my-controls"

@octogonz octogonz added bug Something isn't working as intended help wanted If you're looking to contribute, this issue is a good place to start! effort: easy Probably a quick fix. Want to contribute? :-) labels Jan 20, 2019
@octogonz
Copy link
Collaborator

Thanks for reporting this! I wonder if we should maintain a separate example repo or branch for Yarn.

@iclanton
Copy link
Member

iclanton commented Jul 2, 2019

@apostolisms and I were talking about creating managed samples for each package manager. We should do this.

@KevinTCoughlin
Copy link
Member

@apostolisms and I were talking about creating managed samples for each package manager. We should do this.

👍

This would be useful given my recent (unsuccessful) attempt at using NPM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended effort: easy Probably a quick fix. Want to contribute? :-) help wanted If you're looking to contribute, this issue is a good place to start!
Projects
Status: High priority
Development

No branches or pull requests

4 participants