Skip to content

Commit

Permalink
Add a default on object instantiation of true for invocation.executio…
Browse files Browse the repository at this point in the history
…nSuccessful. (#1534)
  • Loading branch information
michaelcfanning committed Jun 13, 2019
1 parent ddc2b0d commit 76d4cf5
Show file tree
Hide file tree
Showing 4 changed files with 521 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/ReleaseHistory.md
Original file line number Diff line number Diff line change
Expand Up @@ -392,4 +392,5 @@
* BUGFIX: Upgrade schemas to latest version (remove `draft-04` from `$schema` property and change `id` to `$id`). This is necessary because the schemas use the `uri-reference` format, which was not defined in draft-04. https://github.com/microsoft/sarif-sdk/issues/1521
* API BREAKING: The `Init` methods in the Autogenerated SARIF object model classes are now `protected virtual`. This enables derived classes to add additional properties without having to copy the entire code of the `Init` method.
* BUGFIX: Transformation from SARIF 1.0 to 2.x throws ArgumentOutOfRangeException, if `result.locations` is an empty array. https://github.com/microsoft/sarif-sdk/issues/1526
* BUGFIX: Add `Result.Level` (and remove `Result.Rank`) for Fortify Converter based on MicroFocus feedback.
* BUGFIX: Add `Result.Level` (and remove `Result.Rank`) for Fortify Converter based on MicroFocus feedback.
* BUGFIX: Invocation constructor should set 'executionSuccessful' to true by default.
6 changes: 6 additions & 0 deletions src/Sarif/Autogenerated/Invocation.cs
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,12 @@ public SarifNodeKind SarifNodeKind
/// </summary>
public Invocation()
{
// NOTYETAUTOGENERATED: required until https://github.com/microsoft/jschema/issues/95 is fixed
//
// We must dig the pit of success for developers by instantiating an invocation assuming
// a successful invocation. On invocation, producers can set this to false in the
// event of failure.
ExecutionSuccessful = true;
}

/// <summary>
Expand Down
Loading

0 comments on commit 76d4cf5

Please sign in to comment.