Fix #1594: FxCopConverter produces invalid SARIF.

microsoft · Aug 12, 2019 · b026c6e · b026c6e
1 parent feb1953
commit b026c6e
Show file tree

Hide file tree

Showing 4 changed files with 33,297 additions and 36,990 deletions.
diff --git a/src/Sarif.Converters/ConverterResources.Designer.cs b/src/Sarif.Converters/ConverterResources.Designer.cs
diff --git a/src/Sarif.Converters/ConverterResources.resx b/src/Sarif.Converters/ConverterResources.resx
@@ -210,4 +210,7 @@
   <data name="ContrastSecuritySiteRootDescription" xml:space="preserve">
     <value>The root URI of the web site that was analyzed.</value>
   </data>
+  <data name="FxCopNoMessage" xml:space="preserve">
+    <value>FxCop does not provide messages for suppressed results.</value>
+  </data>
 </root>
diff --git a/src/Sarif.Converters/FxCopConverter.cs b/src/Sarif.Converters/FxCopConverter.cs
@@ -121,7 +121,8 @@ internal Result CreateResult(FxCopLogReader.Context context)
             }
 
             result.RuleId = context.CheckId;
-            result.Message = new Message { Arguments = context.Items, Id = context.ResolutionName, Text = context.Message };
+            string messageText = context.Message ?? ConverterResources.FxCopNoMessage;
+            result.Message = new Message { Arguments = context.Items, Id = context.ResolutionName, Text = messageText };
             var location = new Location();
 
             string sourceFile = GetFilePath(context);

diff --git a/src/Test.FunctionalTests.Sarif/v2/ConverterTestData/FxCop/SarifSdkTest.xml.sarif b/src/Test.FunctionalTests.Sarif/v2/ConverterTestData/FxCop/SarifSdkTest.xml.sarif