Reuse fileRegionsCache (#2263)

microsoft · Jan 25, 2021 · df39327 · df39327
1 parent 68d28e6
commit df39327
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/Sarif/FileRegionsCache.cs b/src/Sarif/FileRegionsCache.cs
@@ -14,6 +14,7 @@ namespace Microsoft.CodeAnalysis.Sarif
     /// </summary>
     public class FileRegionsCache
     {
+        public static readonly FileRegionsCache Instance = new FileRegionsCache();
         public const int DefaultCacheCapacity = 100;
         private readonly IFileSystem _fileSystem;
         private readonly Cache<string, Tuple<string, NewLineIndex>> _cache;

diff --git a/src/Sarif/Visitors/InsertOptionalDataVisitor.cs b/src/Sarif/Visitors/InsertOptionalDataVisitor.cs
@@ -100,7 +100,7 @@ public override PhysicalLocation VisitPhysicalLocation(PhysicalLocation node)
                 Region expandedRegion;
                 ArtifactLocation artifactLocation = node.ArtifactLocation;
 
-                _fileRegionsCache ??= new FileRegionsCache();
+                _fileRegionsCache ??= FileRegionsCache.Instance;
 
                 if (artifactLocation.Uri == null && artifactLocation.Index >= 0)
                 {
@@ -117,8 +117,6 @@ public override PhysicalLocation VisitPhysicalLocation(PhysicalLocation node)
                     resolvedUri = artifactLocation.Uri;
                 }
 
-                if (!resolvedUri.IsAbsoluteUri) { goto Exit; }
-
                 expandedRegion = _fileRegionsCache.PopulateTextRegionProperties(node.Region, resolvedUri, populateSnippet: insertRegionSnippets);
 
                 ArtifactContent originalSnippet = node.Region.Snippet;