Skip to content

Commit

Permalink
update comments
Browse files Browse the repository at this point in the history
  • Loading branch information
yongyan-gh committed Dec 1, 2021
1 parent d1928a1 commit fdf350f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions src/Sarif.WorkItems/SarifWorkItemFiler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -292,8 +292,7 @@ public SarifWorkItemModel FileWorkItemInternal(SarifLog sarifLog, SarifWorkItemC

if (sarifLog.Runs?.Any(run => run.Results?.Any(result => result.ShouldBeFiled()) == true) == false)
{
LogMetricsForProcessedModel(sarifLog, null, FilingResult.None);
// if sarifLog does not contains any result should be filed as work item return null
// If the sarifLog does not contains result which should be filed as a work item, return null SarifWorkItemModel.
return null;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ public void WorkItemFiler_SarifLogResultsShouldNotBeFiled()
{
SarifLog sarifLog = TestData.CreateSimpleLog();

// set all results baseline status to unchanged so no file item should be filed
// Set all results' baseline state to 'Unchanged' so no work item should be filed
sarifLog.Runs.SelectMany(run => run.Results).ForEach(result => result.BaselineState = BaselineState.Unchanged);

SarifWorkItemContext context = CreateAzureDevOpsTestContext();
Expand Down

0 comments on commit fdf350f

Please sign in to comment.