Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uri-reference format not supported in draft-04 #1521

Closed
ghost opened this issue Jun 4, 2019 · 1 comment
Closed

uri-reference format not supported in draft-04 #1521

ghost opened this issue Jun 4, 2019 · 1 comment

Comments

@ghost
Copy link

ghost commented Jun 4, 2019

The schema says that certain properties have "format": "uri-reference". But we declare our schema as conforming to draft-04, and uri-reference was not introduced until draft-05 (never released) and officially in draft-06.

We should redeclare the schema as draft-07 (actually https://json-schema.org/specification.html says that "draft-handrews-json-schema-01" is the new versioning hotness). According to https://json-schema.org/draft-06/json-schema-release-notes.html, the only back-compat issue that affects us is the change from id to $id.

This is also filed in oasis-tcs/sarif-spec#421.

@ghost ghost self-assigned this Jun 7, 2019
@ghost ghost added the resolved-fixed label Jun 7, 2019
@ghost
Copy link
Author

ghost commented Jun 7, 2019

Fixed in #1523.

@ghost ghost closed this as completed Jun 7, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants