Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FxCop converter produces invalid SARIF #1594

Closed
michaelcfanning opened this issue Jul 26, 2019 · 0 comments
Closed

FxCop converter produces invalid SARIF #1594

michaelcfanning opened this issue Jul 26, 2019 · 0 comments
Labels
area-conversion bug m156 resolved-fixed

Comments

@michaelcfanning
Copy link
Member

The XML project converter is producing empty messages.

To repro, convert checked in file \src\Test.FunctionalTests.Sarif\v2\ConverterTestData\FxCop\SarifSdkTest.xml

Or run UpdateBaselines.ps1 to regen the relevant SARIF file. Test works today because checked in pre-release v2 transforms properly to valid SARIF v2
@ghost ghost self-assigned this Aug 9, 2019
ghost pushed a commit that referenced this issue Aug 12, 2019
Fix #1594: FxCopConverter produces invalid SARIF.
b026c6e
@ghost ghost closed this as completed in 6e194ec Aug 12, 2019
@ghost ghost added the resolved-fixed label Aug 12, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-conversion bug m156 resolved-fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelcfanning