-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --kind and --level arguments for granular control of results reporting #2228
Comments
For completeness, I will mention that when building this, we should at least consider the possibility we want an even more granular, per-rule mechanism to control reporting behavior. For example: -level Error;BadRuleId.Note might do something like remap BadRuleId's output into a Note (which could be disabled). we should also consider whether this argument could contain a value like 'Disabled' which doesn't literally existing on the SARIF Level type. we could do this because we'll have a string [] representation we can process because constructing the SARIF types. On encountering a Disabled value, we would proactively add this id to the disabled skimmers set. This would provide a super easy way for people to opt out of a poorly behaving check (one that's crashing in general code paths for example). |
…ogger #2228 Remove verbose and largely replace it with "quiet"
…ogger #2228 Renaming, remove quiet from Logging Options
…ogger #2228 Some changes from code review
…2241) * Creating BaseLogger to share methods * removing logmessage from interface * updating more loggers * Fix parameters * Replace verbose in ConsoleLogger. It should know about quiet instead * Remove verbose * Remove unused method * Remove unnecessary nullcheck * fixing functional tests * back to quiet * fixing tests * Use ShouldLog in more locations * Add to release history for breaking change * Fix formatting * Make more loggers children of BaseLogger. Cleanup some functionality with --quiet. Correct some tests * fixing spacing * Rename some parameters, classes, and files. Remove "quiet" from LoggingOptions, and correct unit tests affected * More complete renaming * Rewording, minor cleanup * fixing sample build * Correct validate logic. Remove redundant "none"s * Rename parameters, reword helper text * Add unit tests for DriverExtensionMethod and BaseLogger * Fix casting error * fixing samples compilation issue * Small changes to address comments * Formatting fixes * Address renaming and refactoring comments * More renaming * Change validation in BaseLogger and correct unit tests and code (#2262) * Change validation in BaseLogger and correct unit tests and code broken as a result * Correct formatting * Test SarifLogger honors Kind/Level * Refactor, remove redundant code Co-authored-by: Eddy Nakamura <ednakamu@microsoft.com> Co-authored-by: Eddy Nakamura <eddynaka@gmail.com>
Implementation notes:
@eddynaka
@jameswinkler, FYI
The text was updated successfully, but these errors were encountered: