Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves schemas to current version. #1523

Merged
3 commits merged into from
Jun 7, 2019
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jun 6, 2019

See https://json-schema.org/understanding-json-schema/reference/schema.html. We are declaring that our schemas conform to the latest version of JSON schema, and do not rely on any non-forward-compatible features of previous drafts (such as "id").

See https://json-schema.org/understanding-json-schema/reference/schema.html. We are declaring that our schemas conform to the latest version of JSON schema, and do not rely on any non-forward-compatible features of previous drafts (such as "id").
@ghost ghost requested review from michaelcfanning and harleenkohli June 6, 2019 17:48
@ghost
Copy link
Author

ghost commented Jun 6, 2019

@michaelcfanning is added to the review. #Closed

@ghost
Copy link
Author

ghost commented Jun 6, 2019

@harleenkohli is added to the review. #Closed

@@ -1,7 +1,7 @@
{
"$schema": "http://json-schema.org/draft-04/schema#",
Copy link
Contributor

@harleenkohli harleenkohli Jun 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should update release history! #Resolved

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will do.


In reply to: 291363022 [](ancestors = 291363022)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


In reply to: 291365943 [](ancestors = 291365943,291363022)

Copy link
Contributor

@harleenkohli harleenkohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ghost ghost merged commit 187902d into master Jun 7, 2019
@ghost ghost deleted the users/lgolding/schema-draft-version branch June 7, 2019 16:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant