BUGFIX: Transformation from SARIF 1.0 to 2.x throws Argument-Out-of-Range exception if result.locations is an empty array #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harleenkohli
changed the title
ghost
reviewed
Jun 10, 2019
src/ReleaseHistory.md
Outdated
| * API BREAKING: The `Init` methods in the Autogenerated SARIF object model classes are now `protected virtual`. This enables derived classes to add additional properties without having to copy the entire code of the `Init` method. | ||
| * BUGFIX: Transformation from SARIF 1.0 to 2.x throws Argument-Out-of-Range exception if `result.locations` is an empty array. https://github.com/microsoft/sarif-sdk/issues/1526 |
There was a problem hiding this comment.
Argument-Out-of-Range exceptio [](start = 54, length = 30)
May as well just say the type name ArgumentOutOfRangeException. #Resolved
There was a problem hiding this comment.
harleenkohli
commented
Jun 10, 2019
| "results": [ | ||
| { | ||
| "ruleId": "WS099", | ||
| "level": "error", |
There was a problem hiding this comment.
"level": "error", [](start = 9, length = 18)
Question: ok, i manually edited this before uploading the file. The version which was sent to us had this value as "5". This failed for me when i plugged it as a unit test case. I just want to understand how this works for our customers? where does the enum conversion happen? #WontFix
ghost
reviewed
Jun 10, 2019
| @@ -50,9 +50,11 @@ | |||
| <None Remove="TestData\SarifVersionOneToCurrentVisitor\ExpectedOutputs\MinimumWithLanguage.sarif" /> | |||
| <None Remove="TestData\SarifVersionOneToCurrentVisitor\ExpectedOutputs\NestedInnerExceptionsInNotifications.sarif" /> | |||
| <None Remove="TestData\SarifVersionOneToCurrentVisitor\ExpectedOutputs\OneRunWithAllReportingDescriptors.sarif" /> | |||
| <None Remove="TestData\SarifVersionOneToCurrentVisitor\ExpectedOutputs\WebScout.sarif" /> | |||
There was a problem hiding this comment.
WebScout [](start = 75, length = 8)
This is an internal tool. I suggest:
- Rename it to something like V1ZeroLengthLocationsArray.sarif
- Strip it down to the absolute minimum file that demonstrates the problem. One result, no optional properties... just what you need to trigger the bug. #Resolved
There was a problem hiding this comment.
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
result.locationsis an empty array. Transformation from SARIF 1.0 to 2.x throws Argument-out-of-range exception if result.locations is an empty array #1526