Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1571: FxCop converter doesn't emit run.logicalLocations + add validation rule #1570

Merged
40 commits merged into from
Aug 9, 2019
Merged

Fix #1571: FxCop converter doesn't emit run.logicalLocations + add validation rule #1570

40 commits merged into from
Aug 9, 2019

Commits on Jul 10, 2019

  1. Define rule id and add tests; no rule implementation yet.

    Larry Golding committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    a04aa00 View commit details
    Browse the repository at this point in the history

  2. Implement rule.

    Larry Golding committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    e60baa9 View commit details
    Browse the repository at this point in the history

  3. To aid debugging, implement Region.ToString.

    Larry Golding committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    e6b19a0 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2019

  1. Update SarifValidationSkimmerBase.HelpUri to always point to the late… 

    …st version.
    Larry Golding committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    d2af119 View commit details
    Browse the repository at this point in the history

  2. Prevent validator from emitting empty rule help messages.

    Larry Golding committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    d5b0257 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into users/lgolding/validate-logical-location-i… 

    …ndex
    Larry Golding committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    dd97a7a View commit details
    Browse the repository at this point in the history

  4. Bump version number to 2.1.9.

    Larry Golding committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    64120ea View commit details
    Browse the repository at this point in the history

  5. Shorten rule name to avoid "path name to long" test breaks.

    Larry Golding committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    c90577d View commit details
    Browse the repository at this point in the history

  6. Fix #1571: FxCop converter doesn't emit logical locations.

    Larry Golding committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    c3c7586 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2019

  1. Don't emit empty locations.

    Larry Golding committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    6f59135 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2019

  1. Merge branch 'master' into users/lgolding/validate-logical-location-i… 

    …ndex
    Larry Golding committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    d7fa53d View commit details
    Browse the repository at this point in the history

  2. PR feedback: Don't use object[] for message args.

    Larry Golding committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    240efb8 View commit details
    Browse the repository at this point in the history

  3. PR feedback: One rule for all indices: renames and message fixes.

    Larry Golding committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    83a3103 View commit details
    Browse the repository at this point in the history

  4. Factor out index validation logic.

    Larry Golding committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    7da454e View commit details
    Browse the repository at this point in the history

  5. Validate artifactLocation.index.

    Larry Golding committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    b26133c View commit details
    Browse the repository at this point in the history

  6. DRY out validation logic.

    Larry Golding committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    046d33f View commit details
    Browse the repository at this point in the history

  7. Validate artifact.parentIndex.

    Larry Golding committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    a6cc5a4 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2019

  1. Validate result.ruleIndex.

    Larry Golding committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    d0cc2c4 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2019

  1. Validate address.index.

    Larry Golding committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    4a9c09d View commit details
    Browse the repository at this point in the history

  2. Validate address.parentIndex.

    Larry Golding committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    a848fd7 View commit details
    Browse the repository at this point in the history

  3. Validate threadFlowLocation.index.

    Larry Golding committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    2bb3414 View commit details
    Browse the repository at this point in the history

  4. Validate graphTraversal.{run,result}GraphIndex.

    Larry Golding committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    6a27bf4 View commit details
    Browse the repository at this point in the history

  5. Improve jpointer to offending array.

    Larry Golding committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    408468e View commit details
    Browse the repository at this point in the history

  6. Validate web{request,response}.index.

    Larry Golding committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    99aa70c View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2019

  1. Validate web{Request,Response}.index in threadFlowLocation.

    Larry Golding committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    dbb552f View commit details
    Browse the repository at this point in the history

  2. Validate resultProvenance.invocationIndex.

    Larry Golding committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    4b5773a View commit details
    Browse the repository at this point in the history

  3. Validate invocation.ruleConfigurationOverrides[].descriptor.index

    Larry Golding committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    1949f57 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2019

  1. Validate invocation.notificationConfigurationOverrides[].descriptor.i… 

    …ndex.
    Larry Golding committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    8ea8d6f View commit details
    Browse the repository at this point in the history

  2. Add files omitted from previous commit

    Larry Golding committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    06e6504 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2019

  1. Merge branch 'master' into users/lgolding/validate-logical-location-i… 

    …ndex
    Larry Golding committed Jul 20, 2019
    Configuration menu
    Copy the full SHA
    1d51085 View commit details
    Browse the repository at this point in the history

  2. Validate logicalLocation.parentIndex.

    Larry Golding committed Jul 20, 2019
    Configuration menu
    Copy the full SHA
    b7b16a6 View commit details
    Browse the repository at this point in the history

  3. Validate notification.{descriptor,associatedRule}.index.

    Larry Golding committed Jul 20, 2019
    Configuration menu
    Copy the full SHA
    3894245 View commit details
    Browse the repository at this point in the history

  4. Capitalize "SARIF" in test output.

    Larry Golding committed Jul 20, 2019
    Configuration menu
    Copy the full SHA
    88b9c22 View commit details
    Browse the repository at this point in the history

  5. Validate reportingDescriptorRelationship.target.index.

    Larry Golding committed Jul 20, 2019
    Configuration menu
    Copy the full SHA
    a8098f7 View commit details
    Browse the repository at this point in the history

  6. Validate result.taxa[i].index.

    Larry Golding committed Jul 20, 2019
    Configuration menu
    Copy the full SHA
    4976b3f View commit details
    Browse the repository at this point in the history

  7. Validate threadFlowLocation.taxa[].index.

    Larry Golding committed Jul 20, 2019
    Configuration menu
    Copy the full SHA
    d2b94c4 View commit details
    Browse the repository at this point in the history

  8. Validate reportingDescriptorReference.index for extensions.

    Larry Golding committed Jul 20, 2019
    Configuration menu
    Copy the full SHA
    373d0cc View commit details
    Browse the repository at this point in the history

  9. Validate toolComponentReference.index.

    Larry Golding committed Jul 20, 2019
    Configuration menu
    Copy the full SHA
    d21f3df View commit details
    Browse the repository at this point in the history

  10. Validate toolComponent.associatedComponent.index.

    Larry Golding committed Jul 20, 2019
    Configuration menu
    Copy the full SHA
    2261d1a View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2019

  1. Merge branch 'master' into users/lgolding/validate-logical-location-i… 

    …ndex
    Larry Golding committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    39489e0 View commit details
    Browse the repository at this point in the history