-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1575: SarifSdkTest.xml conversion test does not run. #1646
Conversation
@harleenkohli is added to the review. #Closed |
@SurbhiMS is added to the review. #Closed |
@@ -1 +0,0 @@ | |||
{"$schema":"https://schemastore.azurewebsites.net/schemas/json/sarif-2.1.0-rtm.4.json","version":"2.1.0","runs":[{"results":[{"ruleId":"CA0001","message":{"text":"Engine exception: Microsoft.FxCop.Sdk.InvalidMetadataException: The following error was encountered while reading module 'ManagedPlayToReceiver': Could not resolve member reference: [Windows, Version=255.255.255.255, Culture=neutral, PublicKeyToken=null]Windows.UI.Xaml.SizeChangedEventArgs::get_PreviousSize. at Microsoft.FxCop.Sdk.Reader.HandleError(ModuleNode mod, String errorMessage) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 1048\n at Microsoft.FxCop.Sdk.Reader.GetMemberFromRef(Int32 i, TypeNodeCollection& varArgTypes, Int32 numGenericArgs) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 2408\n at Microsoft.FxCop.Sdk.Reader.GetMemberFromToken(Int32 tok, TypeNodeCollection& varArgTypes) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 2200\n at Microsoft.FxCop.Sdk.InstructionParser.ParseInstruction() in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\InstructionParser.cs:line 274\n at Microsoft.FxCop.Sdk.InstructionParser.ParseInstructions() in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\InstructionParser.cs:line 136\n at Microsoft.FxCop.Sdk.Reader.ParseMethodInstructions(Method method, Int32 methodIndex, Int32 RVA) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 3500\n at Microsoft.FxCop.Sdk.Reader.GetMethodInstructions(Method method, Object i) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 1973\n at Microsoft.FxCop.Sdk.Reader.GetMethodBody(Method method, Object i, Boolean asInstructionList) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 1910\n at Microsoft.FxCop.Sdk.Method.get_Instructions() in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Nodes\\Method.cs:line 251\n at Microsoft.FxCop.Sdk.RuleUtilities.HasImperativeSecurityAction(Method method, SecurityAction action) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\SDK\\RuleUtilities.cs:line 923\n at Microsoft.FxCop.Sdk.RuleUtilities.HasSecurityAction(Method method, SecurityAction action) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\SDK\\RuleUtilities.cs:line 870\n at Microsoft.FxCop.Sdk.RuleUtilities.HasSecurityAction(Method method, SecurityAction[] actions) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\SDK\\RuleUtilities.cs:line 880\n at Microsoft.FxCop.Engines.Introspection.LoadVisitor.RecordCallSites(Method caller) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\LoadVisitor.cs:line 466\n at Microsoft.FxCop.Engines.Introspection.LoadVisitor.VisitMember(Member member, TargetMember target) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\LoadVisitor.cs:line 434\n at Microsoft.FxCop.Engines.Introspection.BaseVisitor.VisitMembers(MemberCollection members, TargetMemberDictionary targets, Boolean visitNestedTypes) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\BaseVisitor.cs:line 184\n at Microsoft.FxCop.Engines.Introspection.BaseVisitor.VisitType(TypeNode type, TargetType target) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\BaseVisitor.cs:line 72\n at Microsoft.FxCop.Engines.Introspection.LoadVisitor.VisitType(TypeNode type, TargetType target) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\LoadVisitor.cs:line 417\n at Microsoft.FxCop.Engines.Introspection.BaseVisitor.VisitTypes(TypeNodeCollection types, TargetNamespaceDictionary targets) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\BaseVisitor.cs:line 131\n at Microsoft.FxCop.Engines.Introspection.LoadVisitor.VisitModule(ModuleNode module, TargetModule target) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\LoadVisitor.cs:line 394\n at Microsoft.FxCop.Engines.Introspection.BaseVisitor.VisitAssembly(AssemblyNode assembly, TargetFile target) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\BaseVisitor.cs:line 37\n at Microsoft.FxCop.Engines.Introspection.LoadVisitor.VisitAssembly(AssemblyNode assembly, TargetFile target) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\LoadVisitor.cs:line 356\n at Microsoft.FxCop.Engines.Introspection.LoadVisitor.Load(TargetFile target, Boolean buildTree, Boolean queueItems, AssemblyNode loadedAssembly) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\LoadVisitor.cs:line 179\n at Microsoft.FxCop.Engines.Introspection.LoadVisittor.LoadAssemblies(Queue queue, ExceptionCollection exceptions) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\LoadVisitor.cs:line 103."},"locations":[{}],"partialFingerprints":{"UniqueId":"Microsoft.FxCop.Sdk.InvalidMetadataException"}},{"ruleId":"CA0001","message":{"text":"Rule CA2001 exception: Microsoft.FxCop.Sdk.InvalidMetadataException: The following error was encountered while reading module 'ManagedPlayToReceiver': Could not resolve member reference: [Windows, Version=255.255.255.255, Culture=neutral, PublicKeyToken=null]Windows.UI.Xaml.SizeChangedEventArgs::get_PreviousSize. at Microsoft.FxCop.Sdk.Reader.HandleError(ModuleNode mod, String errorMessage) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 1048\n at Microsoft.FxCop.Sdk.Reader.GetMemberFromRef(Int32 i, TypeNodeCollection& varArgTypes, Int32 numGenericArgs) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 2408\n at Microsoft.FxCop.Sdk.Reader.GetMemberFromToken(Int32 tok, TypeNodeCollection& varArgTypes) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 2200\n at Microsoft.FxCop.Sdk.InstructionParser.ParseInstruction() in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\InstructionParser.cs:line 274\n at Microsoft.FxCop.Sdk.InstructionParser.ParseInstructions() in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\InstructionParser.cs:line 136\n at Microsoft.FxCop.Sdk.Reader.ParseMethodInstructions(Method method, Int32 methodIndex, Int32 RVA) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 3500\n at Microsoft.FxCop.Sdk.Reader.GetMethodInstructions(Method method, Object i) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 1973\n at Microsoft.FxCop.Sdk.Reader.GetMethodBody(Method method, Object i, Boolean asInstructionList) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 1910\n at Microsoft.FxCop.Sdk.Method.get_Instructions() in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Nodes\\Method.cs:line 251\n at Microsoft.FxCop.Rules.Reliability.AvoidCallingProblematicMethods.Check(Member member) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Rules\\Reliability\\AvoidCallingProblematicMethods.cs:line 76\n at Microsoft.FxCop.Engines.Introspection.AnalysisVisitor.CheckMember(Member memberToAnalyze, Member member, TargetMember target) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\AnalysisVisitor.cs:line 492."},"locations":[{}],"partialFingerprints":{"UniqueId":"ManagedPlayToReceiver.PlayToReceiverPage.#ImgPlayer_SizeChanged(System.Object,Windows.UI.Xaml.SizeChangedEventArgs)#Microsoft.FxCop.Sdk.InvalidMetadataException"}}],"tool":{"driver":{"name":"FxCop"}},"columnKind":"utf16CodeUnits"}]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$schema [](start = 2, length = 7)
File inadvertently committed in a previous PR. #Resolved
@rtaket is added to the review. #Closed |
@cfaucon is added to the review. #Closed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the project file to include SarifSdkTest.xml in the FxCop conversion unit tests. The corresponding .xml.sarif file was already valid, except for a message string that we recently changed. I don't know why, at the time #1575 was filed, the test would fail if you enabled it.