Adding Rule SARIF2012 #1949
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| // Copyright (c) Microsoft. All rights reserved. | ||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
|
|
||
| using System.Collections.Generic; | ||
|
|
||
| namespace Microsoft.CodeAnalysis.Sarif.Multitool.Rules | ||
| { | ||
| public class ProvideHelpUris : SarifValidationSkimmerBase | ||
| { | ||
| /// <summary> | ||
| /// SARIF2012 | ||
| /// </summary> | ||
| public override string Id => RuleId.ProvideHelpUris; | ||
|
|
||
| /// <summary> | ||
| /// Placeholder | ||
| /// </summary> | ||
| public override MultiformatMessageString FullDescription => new MultiformatMessageString { Text = RuleResources.SARIF2012_ProvideHelpUris_FullDescription_Text }; | ||
|
|
||
| protected override IEnumerable<string> MessageResourceNames => new string[] { | ||
| nameof(RuleResources.SARIF2012_ProvideHelpUris_Note_Default_Text) | ||
| }; | ||
|
|
||
| public override FailureLevel DefaultLevel => FailureLevel.Note; | ||
|
|
||
| protected override void Analyze(ReportingDescriptor reportingDescriptor, string reportingDescriptorPointer) | ||
| { | ||
| if (reportingDescriptor.HelpUri == null) | ||
| { | ||
| // {0}: Placeholder | ||
| LogResult( | ||
| reportingDescriptorPointer, | ||
|
There was a problem hiding this comment.
Include the rule's |
||
| nameof(RuleResources.SARIF2011_ProvideContextRegion_Note_Default_Text)); | ||
|
There was a problem hiding this comment.
|
||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| { | ||
| "$schema": "https://schemastore.azurewebsites.net/schemas/json/sarif-2.1.0-rtm.5.json", | ||
| "version": "2.1.0", | ||
| "runs": [ | ||
| { | ||
| "tool": { | ||
| "driver": { | ||
| "name": "SARIF Functional Testing", | ||
| "rules": [ | ||
| { | ||
| "id": "SARIF2012", | ||
| "name": "ProvideHelpUris", | ||
| "shortDescription": { | ||
| "text": "Placeholder." | ||
| }, | ||
| "fullDescription": { | ||
| "text": "Placeholder" | ||
| }, | ||
| "messageStrings": { | ||
| "Note_Default": { | ||
| "text": "{0}: Placeholder" | ||
| } | ||
| }, | ||
| "helpUri": "http://docs.oasis-open.org/sarif/sarif/v2.1.0/sarif-v2.1.0.html" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "invocations": [ | ||
| { | ||
| "toolConfigurationNotifications": [ | ||
| { | ||
| "message": { | ||
| "text": "Rule 'SARIF2002' was explicitly disabled by the user. As result, this tool run cannot be used for compliance or other auditing processes that require a comprehensive analysis." | ||
| }, | ||
| "descriptor": { | ||
| "id": "WRN999.RuleExplicitlyDisabled" | ||
| } | ||
| }, | ||
| { | ||
| "message": { | ||
| "text": "Rule 'SARIF2006' was explicitly disabled by the user. As result, this tool run cannot be used for compliance or other auditing processes that require a comprehensive analysis." | ||
| }, | ||
| "descriptor": { | ||
| "id": "WRN999.RuleExplicitlyDisabled" | ||
| } | ||
| } | ||
| ], | ||
| "executionSuccessful": true | ||
| } | ||
| ], | ||
| "artifacts": [ | ||
| { | ||
| "location": { | ||
| "uri": "FunctionalTestOutput.ValidateCommand/Inputs.SARIF2012.ProvideHelpUris_Invalid.sarif", | ||
| "uriBaseId": "TEST_DIR" | ||
| } | ||
| } | ||
| ], | ||
| "results": [ | ||
| { | ||
| "ruleId": "SARIF2012", | ||
| "ruleIndex": 0, | ||
| "level": "note", | ||
| "message": { | ||
| "id": "Note_Default", | ||
| "arguments": [ | ||
| "runs[0].tool.driver.rules[0]" | ||
| ] | ||
| }, | ||
| "locations": [ | ||
| { | ||
| "physicalLocation": { | ||
| "artifactLocation": { | ||
| "index": 0 | ||
| }, | ||
| "region": { | ||
| "startLine": 11, | ||
| "startColumn": 13 | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "columnKind": "utf16CodeUnits" | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| { | ||
| "$schema": "https://schemastore.azurewebsites.net/schemas/json/sarif-2.1.0-rtm.5.json", | ||
| "version": "2.1.0", | ||
| "runs": [ | ||
| { | ||
| "tool": { | ||
| "driver": { | ||
| "name": "SARIF Functional Testing" | ||
| } | ||
| }, | ||
| "invocations": [ | ||
| { | ||
| "toolConfigurationNotifications": [ | ||
| { | ||
| "message": { | ||
| "text": "Rule 'SARIF2002' was explicitly disabled by the user. As result, this tool run cannot be used for compliance or other auditing processes that require a comprehensive analysis." | ||
| }, | ||
| "descriptor": { | ||
| "id": "WRN999.RuleExplicitlyDisabled" | ||
| } | ||
| }, | ||
| { | ||
| "message": { | ||
| "text": "Rule 'SARIF2006' was explicitly disabled by the user. As result, this tool run cannot be used for compliance or other auditing processes that require a comprehensive analysis." | ||
| }, | ||
| "descriptor": { | ||
| "id": "WRN999.RuleExplicitlyDisabled" | ||
| } | ||
| } | ||
| ], | ||
| "executionSuccessful": true | ||
| } | ||
| ], | ||
| "artifacts": [ | ||
| { | ||
| "location": { | ||
| "uri": "FunctionalTestOutput.ValidateCommand/Inputs.SARIF2012.ProvideHelpUris_Valid.sarif", | ||
| "uriBaseId": "TEST_DIR" | ||
| } | ||
| } | ||
| ], | ||
| "results": [], | ||
| "columnKind": "utf16CodeUnits" | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| { | ||
| "$schema": "https://schemastore.azurewebsites.net/schemas/json/sarif-2.1.0-rtm.5.json", | ||
| "version": "2.1.0", | ||
| "runs": [ | ||
| { | ||
| "tool": { | ||
| "driver": { | ||
| "name": "SARIF Functional Testing", | ||
| "version": "1.0.0", | ||
| "rules": [ | ||
| { | ||
| "id": "SARIF2009", | ||
| "name": "ConsiderConventionalIdentifierValues" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "versionControlProvenance": [ | ||
| { | ||
| "repositoryUri": "https://github.com/microsoft/sarif-sdk" | ||
| } | ||
| ], | ||
| "columnKind": "utf16CodeUnits" | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| { | ||
| "$schema": "https://schemastore.azurewebsites.net/schemas/json/sarif-2.1.0-rtm.5.json", | ||
| "version": "2.1.0", | ||
| "runs": [ | ||
| { | ||
| "tool": { | ||
| "driver": { | ||
| "name": "SARIF Functional Testing", | ||
| "version": "1.0.0", | ||
| "rules": [ | ||
| { | ||
| "id": "SARIF2009", | ||
| "name": "ConsiderConventionalIdentifierValues", | ||
| "helpUri": "http://docs.oasis-open.org/sarif/sarif/v2.1.0/sarif-v2.1.0.html" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "versionControlProvenance": [ | ||
| { | ||
| "repositoryUri": "https://github.com/microsoft/sarif-sdk" | ||
| } | ||
| ], | ||
| "columnKind": "utf16CodeUnits" | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,7 +17,8 @@ | |
| "NoPlaceholders": { | ||
| "text": "This message does not contain dynamic content." | ||
| } | ||
| }, | ||
| "helpUri": "http://docs.oasis-open.org/sarif/sarif/v2.1.0/sarif-v2.1.0.html" | ||
| } | ||
|
There was a problem hiding this comment. we removed these to make the test cases smaller, maybe this got back due to merge. Please remove these (same for other 3 files- 2014, 2015) #ByDesign There was a problem hiding this comment. oh haha! wait a second! now we have a rule which makes this field mandatory!!! lol, now i see why u put it back. In reply to: 447983343 [](ancestors = 447983343) There was a problem hiding this comment. the new rule developed (2012), will show that as an error, since we are using it as verbose. That's why i added again. #Resolved |
||
| ] | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want this for all
reportingDescriptors because SARIF usesreportingDescriptorsin some places that are not rules. Just look atrun.tool.driver.rules(as you have done in other rules). #Closed