ConsoleLogger will expose ExceptionData #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddynaka
commented
Jan 4, 2021
src/Sarif/Writers/ConsoleLogger.cs
Outdated
| if (notification.Exception != null) | ||
| { | ||
| sb.AppendLine(); | ||
| sb.AppendLine(JsonConvert.SerializeObject(notification.Exception)); |
There was a problem hiding this comment.
JsonConvert.SerializeObject(notification.Exception) [](start = 30, length = 51)
Since Exception isn't an exception class, its an ExceptionData class from sarif, it does not expose a ToString which generate all the fields. With that in mind, I switched to serializing it. #Resolved
There was a problem hiding this comment.
Let's write an ExceptionData.ToString() implementation here that mirrors System.Exception.ToString() behavior
In reply to: 551626348 [](ancestors = 551626348)
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2216