-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for git blame. #2358
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request introduces 1 alert when merging c2cb3f3 into 2f3eb01 - view on LGTM.com new alerts:
|
eddynaka
reviewed
May 24, 2021
eddynaka
reviewed
May 24, 2021
eddynaka
reviewed
May 24, 2021
eddynaka
reviewed
May 24, 2021
eddynaka
reviewed
May 24, 2021
eddynaka
reviewed
May 24, 2021
eddynaka
reviewed
May 24, 2021
@eddynaka Made a commit incorporating your suggestions. The unit test for the git blame parser uncovered a couple of bugs! Things are fixed now. Look forward to your feedback. |
eddynaka
reviewed
May 24, 2021
eddynaka
reviewed
May 24, 2021
eddynaka
reviewed
May 24, 2021
eddynaka
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for enriching a SARIF log with
git blame
information. The high level algorithm is as follows:The code changes have been manually tested, but the PR currently does not introduce unit tests for the feature. The problem lies with mocking appropriate external services, since the relevant code creates local objects to interact with these external services (such as
GitHelper
).Also, the
OptionallyEmittedData.All
flag now assumes slightly different semantics, where it implies all flags except the overwrite and git blame flags. This was necessary since the existing test for theOptionallyEmittedData.All
flag does not support the preconditions for git blame.