Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClangTidy read line and row number from log file if exists #2373

Merged
merged 2 commits into from
Jul 16, 2021
Merged

ClangTidy read line and row number from log file if exists #2373

merged 2 commits into from
Jul 16, 2021

Conversation

shaopeng-gh
Copy link
Collaborator

No description provided.

eddynaka
eddynaka reviewed Jul 16, 2021
View reviewed changes
src/Sarif.Converters/ClangTidyConverter.cs
@@ -15,6 +16,7 @@ namespace Microsoft.CodeAnalysis.Sarif.Converters
public class ClangTidyConverter : ToolFileConverterBase
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ClangTidyConverter

Let's also update the md files, showing that we can read the file.yaml.log to understand the line number

@eddynaka eddynaka merged commit 410a7f6 into main Jul 16, 2021
@eddynaka eddynaka deleted the users/shaopeng-gh/clangtidyconsole branch July 16, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddynaka eddynaka eddynaka approved these changes

@michaelcfanning michaelcfanning Awaiting requested review from michaelcfanning michaelcfanning is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaopeng-gh @eddynaka