Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct console output initialization and dispose pattern. #2644

Merged
merged 6 commits into from
Mar 21, 2023

Conversation

michaelcfanning
Copy link
Member

@michaelcfanning michaelcfanning commented Mar 20, 2023

These are interim bugs that never shipped.

They do indicate holes in unit tests (which are currently covered by some other scan tools). We should close these.

{
var logger = new AggregatingLogger();

if (!(analyzeOptions.Quiet == true))
if (!(globalContext.Quiet == true))

Check notice

Code scanning / CodeQL

Unnecessarily complex Boolean expression

The expression '!(A == B)' can be simplified to 'A != B'.
{
var logger = new AggregatingLogger();

if (!(analyzeOptions.Quiet == true))
if (!(globalContext.Quiet == true))

Check notice

Code scanning / CodeQL

Unnecessarily complex Boolean expression

The expression 'A == true' can be simplified to 'A'.
@michaelcfanning michaelcfanning marked this pull request as ready for review March 20, 2023 21:35
@michaelcfanning michaelcfanning merged commit 023b19b into main Mar 21, 2023
@michaelcfanning michaelcfanning deleted the console-logging-and-dispose branch March 21, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant