From ae211d527e79aad138c6425fbd3cf4b2a3bbac2a Mon Sep 17 00:00:00 2001 From: Ben Thomas Date: Fri, 4 Oct 2024 14:31:43 -0700 Subject: [PATCH] Renaming some methods per PM feedback. --- .../Step01/Step01_Processes.cs | 2 +- .../Step02/Step02_AccountOpening.cs | 2 +- .../src/Experimental/Process.Core/ProcessBuilder.cs | 4 ++-- .../Process.UnitTests/ProcessBuilderTests.cs | 2 +- .../src/IntegrationTests/Processes/ProcessTests.cs | 12 ++++++------ 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/dotnet/samples/GettingStartedWithProcesses/Step01/Step01_Processes.cs b/dotnet/samples/GettingStartedWithProcesses/Step01/Step01_Processes.cs index f68fb2059cc8..6b853d7ce4ee 100644 --- a/dotnet/samples/GettingStartedWithProcesses/Step01/Step01_Processes.cs +++ b/dotnet/samples/GettingStartedWithProcesses/Step01/Step01_Processes.cs @@ -38,7 +38,7 @@ public async Task UseSimpleProcessAsync() // Define the behavior when the process receives an external event process - .OnExternalEvent(ChatBotEvents.StartProcess) + .OnInputEvent(ChatBotEvents.StartProcess) .SendEventTo(new ProcessFunctionTargetBuilder(introStep)); // When the intro is complete, notify the userInput step diff --git a/dotnet/samples/GettingStartedWithProcesses/Step02/Step02_AccountOpening.cs b/dotnet/samples/GettingStartedWithProcesses/Step02/Step02_AccountOpening.cs index 8d553bd4fb11..f98632e1788e 100644 --- a/dotnet/samples/GettingStartedWithProcesses/Step02/Step02_AccountOpening.cs +++ b/dotnet/samples/GettingStartedWithProcesses/Step02/Step02_AccountOpening.cs @@ -30,7 +30,7 @@ private KernelProcess SetupAccountOpeningProcess() where TUserIn var crmRecordStep = process.AddStepFromType(); var welcomePacketStep = process.AddStepFromType(); - process.OnExternalEvent(AccountOpeningEvents.StartProcess) + process.OnInputEvent(AccountOpeningEvents.StartProcess) .SendEventTo(new ProcessFunctionTargetBuilder(newCustomerFormStep, CompleteNewCustomerFormStep.Functions.NewAccountWelcome)); // When the welcome message is generated, send message to displayAssistantMessageStep diff --git a/dotnet/src/Experimental/Process.Core/ProcessBuilder.cs b/dotnet/src/Experimental/Process.Core/ProcessBuilder.cs index a30b6d00f090..fa509daebfd5 100644 --- a/dotnet/src/Experimental/Process.Core/ProcessBuilder.cs +++ b/dotnet/src/Experimental/Process.Core/ProcessBuilder.cs @@ -133,7 +133,7 @@ public ProcessBuilder AddStepFromProcess(ProcessBuilder kernelProcess) /// /// The Id of the external event. /// An instance of - public ProcessEdgeBuilder OnExternalEvent(string eventId) + public ProcessEdgeBuilder OnInputEvent(string eventId) { return new ProcessEdgeBuilder(this, eventId); } @@ -144,7 +144,7 @@ public ProcessEdgeBuilder OnExternalEvent(string eventId) /// The Id of the event /// An instance of /// - public ProcessFunctionTargetBuilder GetTargetForExternalEvent(string eventId) + public ProcessFunctionTargetBuilder WhereInputEventIs(string eventId) { Verify.NotNullOrWhiteSpace(eventId); diff --git a/dotnet/src/Experimental/Process.UnitTests/ProcessBuilderTests.cs b/dotnet/src/Experimental/Process.UnitTests/ProcessBuilderTests.cs index 7762c3d93184..de3a9df15159 100644 --- a/dotnet/src/Experimental/Process.UnitTests/ProcessBuilderTests.cs +++ b/dotnet/src/Experimental/Process.UnitTests/ProcessBuilderTests.cs @@ -73,7 +73,7 @@ public void OnExternalEventCreatesEdgeBuilder() var processBuilder = new ProcessBuilder(ProcessName); // Act - var edgeBuilder = processBuilder.OnExternalEvent(EventId); + var edgeBuilder = processBuilder.OnInputEvent(EventId); // Assert Assert.NotNull(edgeBuilder); diff --git a/dotnet/src/IntegrationTests/Processes/ProcessTests.cs b/dotnet/src/IntegrationTests/Processes/ProcessTests.cs index 0c95a97e4403..30dd878bcdbd 100644 --- a/dotnet/src/IntegrationTests/Processes/ProcessTests.cs +++ b/dotnet/src/IntegrationTests/Processes/ProcessTests.cs @@ -70,7 +70,7 @@ public async Task NestedProcessOuterToInnerWorksAsync() // Route the last step of the outer process to trigger the external event that starts the inner process processBuilder.Steps[1].OnEvent(ProcessTestsEvents.OutputReadyInternal) - .SendEventTo(nestedProcessStep.GetTargetForExternalEvent(ProcessTestsEvents.StartProcess)); + .SendEventTo(nestedProcessStep.WhereInputEventIs(ProcessTestsEvents.StartProcess)); // Build the outer process var process = processBuilder.Build(); @@ -111,8 +111,8 @@ public async Task NestedProcessInnerToOuterWorksWithPublicEventAsync() var nestedProcessStep = processBuilder.AddStepFromProcess(this.CreateLinearProcess("Inner")); // Add a new external event to start the outer process and handoff to the inner process directly - processBuilder.OnExternalEvent(ProcessTestsEvents.StartInnerProcess) - .SendEventTo(nestedProcessStep.GetTargetForExternalEvent(ProcessTestsEvents.StartProcess)); + processBuilder.OnInputEvent(ProcessTestsEvents.StartInnerProcess) + .SendEventTo(nestedProcessStep.WhereInputEventIs(ProcessTestsEvents.StartProcess)); // Route the last step of the inner process to trigger the echo step of the outer process nestedProcessStep.OnEvent(ProcessTestsEvents.OutputReadyPublic) @@ -155,8 +155,8 @@ public async Task NestedProcessInnerToOuterDoesNotWorkWithInternalEventAsync() var nestedProcessStep = processBuilder.AddStepFromProcess(this.CreateLinearProcess("Inner")); // Add a new external event to start the outer process and handoff to the inner process directly - processBuilder.OnExternalEvent(ProcessTestsEvents.StartInnerProcess) - .SendEventTo(nestedProcessStep.GetTargetForExternalEvent(ProcessTestsEvents.StartProcess)); + processBuilder.OnInputEvent(ProcessTestsEvents.StartInnerProcess) + .SendEventTo(nestedProcessStep.WhereInputEventIs(ProcessTestsEvents.StartProcess)); // Route the last step of the inner process to trigger the echo step of the outer process nestedProcessStep.OnEvent(ProcessTestsEvents.OutputReadyInternal) @@ -185,7 +185,7 @@ private ProcessBuilder CreateLinearProcess(string name) var echoStep = processBuilder.AddStepFromType(); var repeatStep = processBuilder.AddStepFromType(); - processBuilder.OnExternalEvent(ProcessTestsEvents.StartProcess) + processBuilder.OnInputEvent(ProcessTestsEvents.StartProcess) .SendEventTo(new ProcessFunctionTargetBuilder(echoStep)); echoStep.OnFunctionResult(nameof(EchoStep.Echo))