From 28442098344b76a1a286d5c7137ea334afb18041 Mon Sep 17 00:00:00 2001 From: Leonard Hecker Date: Wed, 22 Jun 2022 01:02:29 +0200 Subject: [PATCH] Dismiss Terminal-by-default banner on handoff (#13344) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It's not useful to notify users that WT can be made the default if it's already clearly being used for handoff. This commit will suppresses the banner then. ## PR Checklist * [x] Closes #13314 * [x] I work here ## Validation Steps Performed * Modify `TerminalPage::ShowSetAsDefaultInfoBar` to not check for `CascadiaSettings::IsDefaultTerminalSet()` * Set Terminal Dev as the default * Set incoming connections to open in the latest Terminal window * Delete `state.json` after every test below * Launching Terminal Dev shows the banner ✅ Launching `cmd.exe` dismisses the banner in the current Terminal ✅ * Launching `cmd.exe` launches Terminal Dev without banner ✅ (cherry picked from commit 24a53d4968f8a1c5648cbc49a4be2d0bc0b28a72) Service-Card-Id: 83434412 Service-Version: 1.14 --- src/cascadia/TerminalApp/TerminalPage.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cascadia/TerminalApp/TerminalPage.cpp b/src/cascadia/TerminalApp/TerminalPage.cpp index 5a7814ad604..fdec1392530 100644 --- a/src/cascadia/TerminalApp/TerminalPage.cpp +++ b/src/cascadia/TerminalApp/TerminalPage.cpp @@ -3251,6 +3251,9 @@ namespace winrt::TerminalApp::implementation // Request a summon of this window to the foreground _SummonWindowRequestedHandlers(*this, nullptr); + + const IInspectable unused{ nullptr }; + _SetAsDefaultDismissHandler(unused, unused); return S_OK; } CATCH_RETURN()