Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quake window doesn't know it was minimized #10689

Closed
vefatica opened this issue Jul 16, 2021 · 3 comments
Closed

Quake window doesn't know it was minimized #10689

vefatica opened this issue Jul 16, 2021 · 3 comments
Labels
Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons.

Comments

@vefatica
Copy link

Windows Terminal version (or Windows build number)

Microsoft Windows 10 Pro for Workstations 10.0.19042.1110 (2009, 20H2) WindowsTerminal: 1.10.1933.0

Other Software

TCC.EXE

Steps to reproduce

From TCC.EXE (JPSoft) running in the Quake terminal, issue activate "%_wintitle" min (_wintitle would be the console's caption if I were in a console; WindowsTerminal uses it as the tab caption).

Expected Behavior

I expect the quake window to be minimized and the taskbar icon to disappear.

Actual Behavior

Either of these give the expected behavior:

  • SendMessage, WM_SYSCOMMAND, SC_MINIMIZE
  • ShowWindow, SW_MINIMIZE

But in response to TCC's ACTIVATE command, the quake window is minimized but the taskbar icon doesn't disappear.

I don't know exactly how TCC's ACTIVATE command works but I've attached a log (plain text) from Spy++ showing what the CASCADIA_HOSTING_WINDOW_CLASS class window sees after that command is issued.

messages.txt

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 16, 2021
@zadjii-msft
Copy link
Member

the quake window is minimized but the taskbar icon doesn't disappear.

This is by design. The _quake window doesn't show up in the taskbar, so it needs to have the tray icon be visible when it's minimized, so that it's still accessible. This was added in #10179, and is going to get some additional flexibility in #10368.

@zadjii-msft zadjii-msft added Issue-Question For questions or discussion Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons. labels Jul 19, 2021
@vefatica
Copy link
Author

This is by design. The _quake window doesn't show up in the taskbar, so it needs to have the tray icon be visible when it's minimized, so that it's still accessible.

Yes, I know that's how it should work, but when minimized with TCC's ACTIVATE command , the window itself disappears, GetWindowPlacement says it's minimized, but the TASKBAR icon is still there (in addition to the tray icon).

@DHowett
Copy link
Member

DHowett commented Jul 19, 2021

@zadjii-msft we probably need to detect when weird software tries to minimize the quake window and trigger a disappear instead of a minimize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons.
Projects
None yet
Development

No branches or pull requests

3 participants