Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font size setting does not work #10973

Closed
leonarduschen opened this issue Aug 18, 2021 · 5 comments · Fixed by MicrosoftDocs/terminal#389
Closed

Font size setting does not work #10973

leonarduschen opened this issue Aug 18, 2021 · 5 comments · Fixed by MicrosoftDocs/terminal#389
Assignees
Labels
In-PR This issue has a related PR Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.

Comments

@leonarduschen
Copy link

Windows Terminal version (or Windows build number)

1.9.1942.0

Other Software

No response

Steps to reproduce

Change font size directly JSON settings file

Below is what my "profiles" section looks like

    "profiles": {
        "defaults": {
            "font": {
                "size": 40,
                "weight": "normal"
            }
        },
        "list": [
            {
                "commandline": "powershell.exe",
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "hidden": false,
                "name": "Windows PowerShell"
            },
            {
                "commandline": "cmd.exe",
                "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
                "hidden": false,
                "name": "Command Prompt"
            },
            {
                "guid": "{07b52e3e-de2c-5db4-bd2d-ba144ed6c273}",
                "hidden": false,
                "name": "Ubuntu-20.04",
                "source": "Windows.Terminal.Wsl",
                "startingDirectory": "\\\\wsl$\\Ubuntu-20.04\\home\\leonarduschen",
            },
            {
                "guid": "{b453ae62-4e3d-5e58-b989-0a998ec441b8}",
                "hidden": false,
                "name": "Azure Cloud Shell",
                "source": "Windows.Terminal.Azure"
            }
        ]
    },

Expected Behavior

Font size gets smaller

Actual Behavior

No font size changes in any of the profiles

image

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 18, 2021
@DHowett
Copy link
Member

DHowett commented Aug 18, 2021

Thanks for the report! @PankajBhojwani, do you know if the new modern font syntax is in 1.9? I suspect that it might be 1.10 only and this is a documentation issue.

@zadjii-msft
Copy link
Member

Judging by #10433 (comment), and the lack of a paired comment for 1.9, I'm thinking that this is 1.10 only.

@zadjii-msft zadjii-msft added Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Aug 18, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.11 milestone Aug 18, 2021
@leonarduschen
Copy link
Author

Right, using fontSize works !

So am I correct to say the documentation here https://docs.microsoft.com/en-us/windows/terminal/ is in general always more up to date then latest release (i.e., currently 1.9) ?

@zadjii-msft zadjii-msft self-assigned this Aug 18, 2021
@zadjii-msft
Copy link
Member

The docs are usually updated in tandem with features getting merged, but something like this should have had a little "Notes" section to indicate that this feature was only in 1.10+, and what to do in <=1.9. I'll go update those now.

@PankajBhojwani
Copy link
Contributor

I suspect that it might be 1.10 only and this is a documentation issue.

My thoughts as well!

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In-PR This issue has a related PR Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants