-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a minimizeToNotificationArea
action
#11229
Comments
I've been meaning to make a contribution to WT for a long time - so I wanted to ask - if this isn't already implemented/being worked on, would it make a good beginner's issue? |
Part of the reason why that action wasn't implemented during that PR is because we weren't totally sold on how it should all work. The only way it could work right now is if the user already has However, trying to implement this action to work even with Also, the action should technically be named |
minimizeToTray
actionminimizeToNotificationArea
action
What would be the response if a user tries to invoke the |
I can think of two things:
|
I feel doing nothing is better than doing something else. On an unrelated note: pardon me for the stupid question, but what exactly happens when an app goes to the tray? Since the window is no longer visible, does it mean it is consuming less resources (which would have been used otherwise for drawing/painting the window and/or managing related memory/CPU time)? Of course the pwsh (or equivalent) process will continue to consume the same resource as before as it's still running in the background. |
I'm pretty sure that nothing special happens. It's basically just the same as being in the taskbar, but with one less window snapshot to draw in alt+tab & win+tab. So I'd presume the difference is negligible. |
Yeah I originally had the action implemented but left it out of the initial PR to stew on it a bit more. Then I got caught up in doing other things and forgot to put out a separate PR with this action 😅 IMO I like the idea of having the action work even with Though with that behavior, like @zadjii-msft said, it would require per-window tracking of minimized or not, making it more complicated to impl. If it's something you're interested in taking on though, by all means go for it! |
I was thinking about this too - because currently IIRC we don't have any actions that are dependent on a global setting.
I'll be honest - I think it'll be too much for me 😅. I just know college-level C++ and have never worked on any project this large/complex. I have one other (unrelated) feature request that might be easier to get me started (I'll open an issue sometime later today). Edit: Oops, I just saw that it has already been done - #11116 |
Discussed with the team:
|
Description of the new feature/enhancement
When the
minimizeToTray
property is set to true, the window gets minimized to the tray on clicking the minimize button on top right. I feel this is not always a desirable response - people might want to minimize to taskbar (the normal behavior) or minimize to tray, separately. An action calledminimizeToTray
(and a way to set a keybinding for this) would work best - allowing for both behaviors according to what the users want.This will also allow WT to behave similar to tmux's
detach
- where detaching and minimizing (to taskbar) are distinct behaviors.Proposed technical implementation details (optional)
I was reading the discussion here at #10368 (comment) - was this action not implemented?
The text was updated successfully, but these errors were encountered: