Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for automatic replies ala VsCode #12366

Closed
zadjii-msft opened this issue Feb 4, 2022 · 3 comments
Closed

Add support for automatic replies ala VsCode #12366

zadjii-msft opened this issue Feb 4, 2022 · 3 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Milestone

Comments

@zadjii-msft
Copy link
Member

https://code.visualstudio.com/updates/v1_64#_automatic-replies

Something like their syntax:

"terminal.integrated.autoReplies": {
  "[Oh My Zsh] Would you like to check for updates? [Y/n]": "Y\r",
  "Terminate batch job (Y/N)": null
}

Might even be able to close out #217 with this 👀

There'd be obvious edge cases where a string is split over many writes, but that might be acceptable.

The perf hit would be the thing I'd be most worried about. We'd need to have a very clever way of not impacting throughput too much.

@zadjii-msft zadjii-msft added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. labels Feb 4, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Feb 4, 2022
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 4, 2022
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 7, 2022
@zadjii-msft
Copy link
Member Author

brain blast: it's gotta accept capture groups and the ability to reference them in the reply.

Consider:

fatal: The current branch dev/migrie/fhl/menu-complete-prototype has no upstream branch.
To push the current branch and set the remote as upstream, use

    git push --set-upstream origin dev/migrie/fhl/menu-complete-prototype

match on

"autoReplies": {
    "    git push --set-upstream origin (.*)": "git push --set-upstream origin ${match[0]}"
}

to automatically output

git push --set-upstream origin dev/migrie/fhl/menu-complete-prototype

<pseudo-spec>

@zadjii-msft
Copy link
Member Author

I'm just tracking this in /dup #5916 at this point.

@ghost
Copy link

ghost commented Sep 9, 2022

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Sep 9, 2022
@ghost ghost added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Sep 9, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

1 participant