Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbound profile shortcuts ctrl+shift+<n> still shows on new tab menu #15418

Closed
giggio opened this issue May 24, 2023 · 2 comments
Closed

Unbound profile shortcuts ctrl+shift+<n> still shows on new tab menu #15418

giggio opened this issue May 24, 2023 · 2 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@giggio
Copy link

giggio commented May 24, 2023

Windows Terminal version

1.18.1421.0

Windows build number

10.0.22621.0

Other Software

No response

Steps to reproduce

Unbind one of the profiles actions.
In the settings.json:

{
    "actions": [
        {
            "command": "unbound",
            "keys": "ctrl+shift+7"
        }
    ]
}

The shortcut will no longer work, but will still show on the new tab menu.

Expected Behavior

Shortcut does not show on new tab menu.

Actual Behavior

Shortcut shows on new tab menu.

@giggio giggio added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 24, 2023
@zadjii-msft
Copy link
Member

Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #13943 for more discussion.

/dup #13943

@microsoft-github-policy-service
Copy link
Contributor

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service microsoft-github-policy-service bot added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants