Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set/change line-height on focus-mode toggle #17018

Closed
yavorski opened this issue Apr 4, 2024 · 1 comment
Closed

Ability to set/change line-height on focus-mode toggle #17018

yavorski opened this issue Apr 4, 2024 · 1 comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements

Comments

@yavorski
Copy link

yavorski commented Apr 4, 2024

Description of the new feature/enhancement

Ability to set/change the line-height/cellHeight when you toggle focus mode.


When entering focus mode geometry is changed so neovim is receiving the unwanted/wasted/not used space on bottom.
In order to remove the neovim bottom unwanted space I want to be able to set/change the line-height on focus mode toggle.

Suggestion

Add focus-mode-defaults setting in config.json where we can specify the font cellHeight when focus mode is enabled.

Thank you!

@yavorski yavorski added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Apr 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 4, 2024
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 10, 2024
@carlos-zamora
Copy link
Member

Thanks for the feature request. We've discussed this as a team and we feel that it might be too niche.

Somewhat related: #11111
That issue refers to admin-specific customizations, but the team has discussed in the past the idea of extending that to "focus mode" customizations as well. It's really the same problem all around: how do we determine which appearance to use when there's an intersection of "unfocused", "admin", and (in this case) "focus mode".

@carlos-zamora carlos-zamora closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements
Projects
None yet
Development

No branches or pull requests

2 participants